Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null previousState in BlocBuilder condition #329

Merged
merged 1 commit into from Jun 2, 2019

Conversation

felangel
Copy link
Owner

@felangel felangel commented Jun 2, 2019

Status

READY

Breaking Changes

NO

Description

Todos

  • Tests
  • Documentation
  • Examples

Impact to Remaining Code Base

None

@felangel felangel added the bug Something isn't working label Jun 2, 2019
@felangel felangel requested a review from jorgecoca June 2, 2019 05:05
@felangel felangel self-assigned this Jun 2, 2019
@felangel felangel added this to In progress in bloc Jun 2, 2019
@codecov
Copy link

codecov bot commented Jun 2, 2019

Codecov Report

Merging #329 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #329   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         162    163    +1     
=====================================
+ Hits          162    163    +1
Impacted Files Coverage Δ
packages/flutter_bloc/lib/src/bloc_builder.dart 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e2738...673a8ad. Read the comment docs.

@felangel felangel merged commit eedd3df into master Jun 2, 2019
@felangel felangel deleted the fix/blocbuilder-condition branch June 2, 2019 05:18
@felangel felangel moved this from In progress to Done in bloc Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
bloc
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant