add test_x_is_y tests from git #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarcat
added a commit
to anarcat/Git-Mediawiki
that referenced
this pull request
Nov 22, 2017
Reported upstream as felipec/sharness#60
anarcat
added a commit
to anarcat/Git-Mediawiki
that referenced
this pull request
Nov 22, 2017
Reported upstream as felipec/sharness#60
|
Yeah, this LGTM. Thanks! |
|
So I forgot to update this PR unfortunately, but there are two more tests missing that we're using in the Git-Mediawiki project, as you can see in our final commit: anarcat/Git-Mediawiki@06694fd#diff-1a3e5e27180742ac2f268d7df5e0d30bR99 Those are |
|
Updates from the Git side are made when someone needs something that has already been implemented on the Git side. So I would suggest sending another commit with the 2 functions that are missing. |
|
okay, will do thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.