-
Notifications
You must be signed in to change notification settings - Fork 61
Remove dependency on ZipFiles.jl and EzXML.jl #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on ZipFiles.jl and EzXML.jl #280
Conversation
Remove remaining dependency on ZipFile.jl
overloaded findall() and findfirst() functions and a single call to EzXMLunlnk().
function that uses the XML.jl API.
|
There are a couple of other things to point out:
|
|
This is great. I can try and help review how ZipArchives.jl is used here. One thing to look into is memory usage when reading a large spreadsheet. |
|
Thank you @nhz2. I saw that |
|
Pure awesomeness. Thanks @TimG1964 ! |
This PR follows previous attempts and helpful feedback on Discourse here, and here. There was another thread, too, but I can't find it now. (EDIT Not a discourse thread but comments on a previous PR, here. I think I've followed all of @nhz2's advice in this PR.)
I've removed all dependence on both ZipFiles.jl (in favour of ZipArchives.jl) and EzXML.jl (in favour of XML.jl). I could not replace ZipFiles until after I had replaced EzXML, but EzXML was used ubiquitously throughout the XLSX package so replacing it was a comparatively big task.
Some important caveats:
I have relied on the heavy lifting done by @felipenoris throughout.
This PR passes all tests locally and works perfectly in my use case, which gives some confidence in making this PR. However, I think it will still need review by a competent person both for correctness and for efficiency. I haven't benchmarked, but it seems, subjectively, to be about the same speed as before.