Cursor jumps to start of line when typing curly brace in JSX property

[dentafrice]

Hi!

Thanks for your work on rjsx-mode.

I'm encountering an issue adding properties to an element. Curly braces seem to trigger a re-indent of the line and cause the cursor to jump to the beginning of the line.

I've recorded a few different examples here.

I'm experiencing this issue in Spacemacs, but I've tried to reproduce this in as bare of an emacs configuration as I can. This is my first time filing an issue with an emacs package, please let me know if there's any additional information that I can provide or if I'm doing something stupid here.

Zero configuration

rjsx-mode

Opening a curly brace de-indents line, closing a curly re-indents (incorrectly to 2 spaces) and places cursor at the beginning of line.

js2-jsx-mode:

Opening a curly brace de-indents the line, closing doesn't fix it. Cursor stays in place.

Fixing indent level

I noticed that by default js-indent-level is 4, and sgml-basic-offset is 2. I added the following code to init.el to make them equal.

(setq-default
 js-indent-level 4
 sgml-basic-offset 4)

This seems to fix the indention issues completely in both modes, but rjsx-mode's cursor still jumps to the beginning of the line.

rjsx-mode

js2-jsx-mode

init.el

(require 'package)
(add-to-list 'package-archives '("melpa" . "http://melpa.org/packages/"))

(setq package-list
    '(rjsx-mode))

; activate all the packages
(package-initialize)

; fetch the list of packages available
(unless package-archive-contents
  (package-refresh-contents))

; install the missing packages
(dolist (package package-list)
  (unless (package-installed-p package)
    (package-install package)))

Versions

GNU Emacs 26.1
rjsx-mode: 20180823.1645
js2-mode: 20180724.801

[dentafrice]

After additional testing, I think this issue may have been introduced in eae8137.

I'm unable to reproduce this issue on commits prior to that change. For example, running 3f7efda:

[dentafrice]

After additional testing, I think this issue may have been introduced in eae8137.

I'm unable to reproduce this issue on commits prior to that change. For example, running 3f7efda:

[felipeochoa]

Thanks for bisecting. I'm having this issue with the new indentation code, so I'm assuming you have some sort of electric mode (e.g., smartparens) that tries to reindent when you type a curly brace.

[felipeochoa]

Thanks for bisecting. I'm having this issue with the new indentation code, so I'm assuming you have some sort of electric mode (e.g., smartparens) that tries to reindent when you type a curly brace.

[qhuyduong]

I'm facing the same issue. Look forward to seeing the fix soon.

[qhuyduong]

I'm facing the same issue. Look forward to seeing the fix soon.

[felipeochoa]

If you want to see it sooner, it's probably just a fix on rjsx-indent-line. PRs welcome 😉

[felipeochoa]

If you want to see it sooner, it's probably just a fix on rjsx-indent-line. PRs welcome 😉

[dentafrice]

so I'm assuming you have some sort of electric mode (e.g., smartparens) that tries to reindent when you type a curly brace.

Unless I'm misunderstanding, I'm reproducing this on a clean emacs installation with just js2-mode and rjsx-mode installed.

I don't think there's any external mode/package interference going on here.

[dentafrice]

so I'm assuming you have some sort of electric mode (e.g., smartparens) that tries to reindent when you type a curly brace.

Unless I'm misunderstanding, I'm reproducing this on a clean emacs installation with just js2-mode and rjsx-mode installed.

I don't think there's any external mode/package interference going on here.

[danielmt]

It's happening typing dots too, on jsx files. It jumps back to the start of the line, typing dots anywhere (even on just text within tags).

[danielmt]

It's happening typing dots too, on jsx files. It jumps back to the start of the line, typing dots anywhere (even on just text within tags).

[qhuyduong]

@felipeochoa I have opened a pull request for this issue. Please check.

[qhuyduong]

@felipeochoa I have opened a pull request for this issue. Please check.

[jinhale]

Typing a comma will do this as well as long as the comma separates items of an array in an attribute's properties.

[jinhale]

Typing a comma will do this as well as long as the comma separates items of an array in an attribute's properties.

[gustavo-depaula]

Suffering with this problem as well! 👍 Using doom-emacs here

[gustavo-depaula]

Suffering with this problem as well! 👍 Using doom-emacs here

[qleguennec]

Same issue here, using doom-emacs

[qleguennec]

Same issue here, using doom-emacs

[trev-dev]

@felipeochoa Thank you for the PR!!

[trev-dev]

@felipeochoa Thank you for the PR!!

[DoMiNeLa10]

I've been experiencing this problem as well recently, and I'm glad it got resolved before I got to updating rjsx-mode.

[DoMiNeLa10]

I've been experiencing this problem as well recently, and I'm glad it got resolved before I got to updating rjsx-mode.

[deviantfero]

I was having this issue as well, it has been resolved, just stopping by to say thanks for such a wonderful package!

[deviantfero]

I was having this issue as well, it has been resolved, just stopping by to say thanks for such a wonderful package!