Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/hide share if not supported #232

Merged
merged 5 commits into from Jan 2, 2024

Conversation

felix-berlin
Copy link
Owner

No description provided.

@felix-berlin felix-berlin self-assigned this Jan 2, 2024
Copy link

what-the-diff bot commented Jan 2, 2024

PR Summary

  • Astro.js Vue Dependency Update
    The latest version of Astro.js Vue has been added to our project dependencies. This helps us have access to the newest features and fixes that the library offers.

  • Browser Popover Support Check
    We've improved our notification system to check whether the user's browser can show popovers. This helps deliver a smoother user experience with toasts notifications.

  • Conditional Rendering of Buttons
    The buttons in the word options dropdown now render based on whether the browser supports certain features like sharing and clipboard functionalities. This optimizes our user interface according to each user's device capabilities.

  • Removal of Unused Icons and Component
    Certain unused icons and the "Navigate back" component have been removed from the code. This helps in keeping our codebase clean and efficient.

  • Improved Use of Toast Notifications and Hooks
    We've made our toast notifications more intelligent; they won't execute if the necessary features aren't supported by the user's browser. Moreover, updates have been made to certain functions in the hooks of WordOptionDropdown to ensure a better functioning of features like clipboard copying and sharing.

  • Removal of "IsWordOfTheDay" Component
    The IsWordOfTheDay component, which was no longer needed, has been removed from the pages. This again contributes to cleaning the codebase and making the project more maintainable.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (809258d) 15.46% compared to head (e4ae52e) 15.62%.

Files Patch % Lines
src/components/word/WordOptionDropdown.vue 0.00% 8 Missing ⚠️
src/stores/toastNotify.ts 63.63% 4 Missing ⚠️
src/components/toast/ToastNotify.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   15.46%   15.62%   +0.16%     
==========================================
  Files          61       61              
  Lines        3982     3986       +4     
  Branches       71       71              
==========================================
+ Hits          616      623       +7     
+ Misses       3316     3313       -3     
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-pages bot commented Jan 2, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e4ae52e
Status: ✅  Deploy successful!
Preview URL: https://96d26ba8.berliner-schnauze.pages.dev
Branch Preview URL: https://bugfix-hide-share-if-not-sup.berliner-schnauze.pages.dev

View logs

Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
astro 4.0.8...4.0.9 None +0/-0 14.2 MB fredkschott

@felix-berlin felix-berlin merged commit 5b3007b into main Jan 2, 2024
9 checks passed
@felix-berlin felix-berlin deleted the bugfix/hide-share-if-not-supported branch January 2, 2024 20:43
@felix-berlin
Copy link
Owner Author

🎉 This PR is included in version 3.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant