Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PWA): hide button if installed #233

Merged
merged 3 commits into from Jan 2, 2024

Conversation

felix-berlin
Copy link
Owner

No description provided.

@felix-berlin felix-berlin self-assigned this Jan 2, 2024
Copy link

what-the-diff bot commented Jan 2, 2024

PR Summary

  • Addition of 'Installed' Paragraph Slot in 'Footer.astro' File
    In the Footer.astro file, there is now a new section called the "installed" slot. This is part of the InstallApp component, and gives us a new area where we can share additional information. This could be used for a number of purposes, such as explaining the installation status of the app, providing instructions for next steps, or conveying any relevant updates.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (8a9c222) 15.62% compared to head (5c89471) 15.73%.

Files Patch % Lines
src/components/InstallApp.vue 0.00% 11 Missing ⚠️
src/stores/installApp.ts 57.14% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   15.62%   15.73%   +0.10%     
==========================================
  Files          61       61              
  Lines        3986     4010      +24     
  Branches       71       71              
==========================================
+ Hits          623      631       +8     
- Misses       3313     3329      +16     
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-pages bot commented Jan 2, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5c89471
Status: ✅  Deploy successful!
Preview URL: https://3015158f.berliner-schnauze.pages.dev
Branch Preview URL: https://feature-hide-pwa-if-installe.berliner-schnauze.pages.dev

View logs

@felix-berlin felix-berlin merged commit 7b87fd0 into main Jan 2, 2024
9 checks passed
@felix-berlin felix-berlin deleted the feature/hide-pwa-if-installed branch January 2, 2024 21:55
@felix-berlin
Copy link
Owner Author

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant