Skip to content

Conversation

@cweagans
Copy link
Contributor

@cweagans cweagans commented Feb 2, 2017

Ref #267

Hoping this fixes global installs.

@codecov
Copy link

codecov bot commented Feb 2, 2017

Codecov Report

Merging #268 into master will not impact coverage.

@@            Coverage Diff             @@
##             master     #268    +/-   ##
==========================================
  Coverage     88.59%   88.59%            
- Complexity        0      703   +703     
==========================================
  Files            51       51            
  Lines          1412     1412            
==========================================
  Hits           1251     1251            
  Misses          161      161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8823bc...7569837. Read the comment docs.

@felixfbecker
Copy link
Owner

Can you confirm that the bug in squizlabs/PHP_CodeSniffer#1218 does not appear on your branch?

@cweagans
Copy link
Contributor Author

cweagans commented Feb 2, 2017

I can confirm that the code added by the commits in that issue are present in RC2, which is what composer installed for me. Since that's what Travis installed (https://travis-ci.org/felixfbecker/php-language-server/builds/197497074#L293), I think it's good.

@cweagans
Copy link
Contributor Author

cweagans commented Feb 2, 2017

I can also confirm that the tests run successfully locally.

@felixfbecker felixfbecker merged commit 7fbd68a into felixfbecker:master Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants