Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

getDoc: added '?attachments=' #39

Merged
merged 1 commit into from May 18, 2012

Conversation

Projects
None yet
3 participants
Contributor

0xDB commented May 18, 2012

Hi!

I added support for '?attachments=' to getDoc.

I realize adding an options-object as parameter would be better than two optional parameters, but it would break programs already using the function with the rev parameter.

I would also like to add the option for '?atts_since=' some time soon, but that would definitely require an options-parameter of some sort.

Also, I'm new to Javascript and GitHub. If i did something in the wrong way, constructive criticism would be very helpful :)

Kind Regards,
Daniel

Collaborator

mcoolin commented May 18, 2012

Let me take a look and figure out git. I do have a merge option!

@mcoolin mcoolin added a commit that referenced this pull request May 18, 2012

@mcoolin mcoolin Merge pull request #39 from 0xDB/master
getDoc: added '?attachments='
56a1a30

@mcoolin mcoolin merged commit 56a1a30 into felixge:master May 18, 2012

ge-org commented May 21, 2012

Not only ?atts_since= would be cool, but also ?revs_info= and ?revs=
http://wiki.apache.org/couchdb/HTTP_Document_API#Special_Fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment