Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fix comma error introduced in refactoring

  • Loading branch information...
commit df18901a84b77f020c1b1c7fea8eede0bd1c69ba 1 parent 229dc69
@felixge authored
Showing with 4 additions and 3 deletions.
  1. +2 −1  Readme.md
  2. +1 −1  lib/formidable/incoming_form.js
  3. +1 −1  package.json
View
3  Readme.md
@@ -35,7 +35,8 @@ Note: Formidable requires [gently](http://github.com/felixge/node-gently) to run
Parse an incoming file upload.
var formidable = require('formidable'),
- http = require('http')
+ http = require('http'),
+
sys = require('sys');
http.createServer(function(req, res) {
View
2  lib/formidable/incoming_form.js
@@ -1,6 +1,6 @@
if (global.GENTLY) require = GENTLY.hijack(require);
-var util = require('./util')
+var util = require('./util'),
path = require('path'),
File = require('./file'),
MultipartParser = require('./multipart_parser').MultipartParser,
View
2  package.json
@@ -2,5 +2,5 @@
"version": "0.9.9",
"dependencies": {"gently": ">=0.7.0"},
"directories" : { "lib" : "./lib/formidable" },
- "main" : "./lib/formidable/index",
+ "main" : "./lib/formidable/index"
}

3 comments on commit df18901

@aheckmann

Comma first! :p

@felixge
Owner

Well, JSON is fucking stupid for not allowing a trailing comma. But since V8 doesn't care for JavaScript itself it's usually not a problem.

Anyway - I agree, comma-first was nice, but since nobody else seems to embrace it I'd rather go with an accepted convention for my modules.

@aheckmann

Twice in the past two weeks I've been bitten by this exact issue in older code. Yeah, it'd be great if more people began using it. I'm glad I've switched.

Please sign in to comment.
Something went wrong with that request. Please try again.