Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

We’re showing branches in this repository, but you can also compare across forks.

base fork: felixge/node-formidable
base: v0.9.2
head fork: felixge/node-formidable
compare: new-parser
Commits on Jun 26, 2010
Felix Geisendörfer Fix: node > 0.1.98 compatibility 37e00ac
Felix Geisendörfer Bump version a6922ef
Commits on Jun 29, 2010
Felix Geisendörfer Fix: Handle pause() calls on destroyed uploads
This patch also improves the behavior for resume().

net.Stream currently does not guarantee 'data' to stop emitting after
pausing a stream. This makes the current throttling function
problematic and prone to race conditions. This patch will take of it
for now, but a further patch for node itself will make things even
Felix Geisendörfer Bump version 857559e
Commits on Jul 13, 2010
Felix Geisendörfer Add missing err parameter to docs f92b1db
Commits on Jul 15, 2010
Felix Geisendörfer Feature: IncomingForm.timeout
By default uploads that are not receiving data for longer than 30
seconds will now emit an error.
Felix Geisendörfer Bump version 464fc9d
Commits on Jul 16, 2010
Felix Geisendörfer Revert "Feature: IncomingForm.timeout"
This reverts commit 5e2612c.

There seems to be problems with this, causing non-stalled uploads to
report timeouts as well. Need to investigate.
Commits on Jul 17, 2010
Felix Geisendörfer Fix: Handling of empty header values and field data
This patch introduces two new events to the multipart parser:
'onHeaderEnd' and 'onHeadersEnd'. These make it much easier to properly
handle the output of the parser.

Another nice addition is a system test that verifies a complete upload
from start to finish.
Felix Geisendörfer Add .npmignore file 3b67d93
Felix Geisendörfer Make clean for test/tmp bf21f0c
Felix Geisendörfer Feature: IncomingForm.maxFieldSize
The parser is now considered safe. A malicious client can no longer
allocate huge amounts of memory by sending a big field.
Felix Geisendörfer Bump version 18de5c6
Felix Geisendörfer Added ports section 52e0ea9
Felix Geisendörfer Renamed maxFieldSize to maxFieldsSize 9f970b7
Felix Geisendörfer Bump version 3f11e89
Commits on Jul 28, 2010
Felix Geisendörfer Work around race condition
It seems like connections are dying randomly when not sending
a content-length header.
Commits on Sep 08, 2010
James Halliday substack can now just do `new formidable` e94f24e
James Halliday substack `formdiable()` now does the same thing as `new formidable` 6e5c78b
Felix Geisendörfer Test cases for substack's patches 8f5e7f4
Felix Geisendörfer Bump version 6ccf2d5
Commits on Sep 17, 2010
Felix Geisendörfer Fix: Handle quotes in filenames 7b60942
Commits on Oct 18, 2010
Felix Geisendörfer Compatibility with node HEAD 720f4a3
Felix Geisendörfer Missing module for previous commit 77b9465
Felix Geisendörfer Feature: incomingForm 'fileBegin' event
This event is useful if you need to buffer the uploaded file to disk, but
you are interested in streaming it to somewhere else while it is still
being uploaded.

You may need this if you are streaming the file to a destination that is
potentially slower at receiving it than the client that is uploading. By
buffering to disk you can ensure maximum upload speed for the client, while
having the flexibility to streaming the file on disk with a different speed.
Felix Geisendörfer Refactoring addListener -> on 0e54a07
Felix Geisendörfer Go back to traditional coding style
Comma first doesn't seem light it has caught on, so this commit changes
the projects coding style back to the Google-ish standard formatting.
Commits on Oct 19, 2010
Felix Geisendörfer Bump version 229dc69
Commits on Oct 24, 2010
Felix Geisendörfer Fix comma error introduced in refactoring df18901
Commits on Oct 30, 2010
Felix Geisendörfer Better project description
Also added a paragraph about the state of the module with a tiny advertisment for
transloadit ; ).
Commits on Nov 12, 2010
Felix Geisendörfer Fix global variable leak
See report here: 792503a#L0R252
Commits on Nov 25, 2010
Felix Geisendörfer Make Makefile more portable 66fbaae
Commits on Dec 07, 2010
Aaron Heckmann aheckmann fix global var leaks (comma last issue) 8e6cb2e
Commits on Dec 15, 2010
Jacek Becela ncr Remove parsing of optional CRLF epilogoue, change parser so it ignore…
…s everything after last boundary
Felix Geisendörfer Bringing back the old rfc1867 test
The test without the trailing \r\n is now a separate test.
Felix Geisendörfer Bump version 2b02144
Commits on Dec 19, 2010
Tim Koschuetzki tim-kos Emit 'progress' event before parsing data
The 'progress' event is meant to indicate upload progress, not parsing
progress. This patch puts things into the right order.
Commits on Jan 18, 2011
Felix Geisendörfer Workaround stupid new node feature
This is only needed for the test suite.
Felix Geisendörfer Use HTML5 FileAPI properties for File class
This does not break backwards compatiblity yet, but future
versions will remove the old property alias.

Felix Geisendörfer Implement lastModifiedDate
Completes the basic HTML5 API compatibility from a property point of
Felix Geisendörfer Add changelog to readme
Not documenting the old releases for now

Also moved Todo into own file
Felix Geisendörfer Compact older releases 85b6d13
Felix Geisendörfer Update docs 129b51e
Felix Geisendörfer Bump version 63347d8
Commits on Mar 16, 2011
Jeff Craig foxxtrot Add support for multipart boundaries that are quoted strings. 88cc9c8
Commits on Mar 29, 2011
Felix Geisendörfer Make npm ignore vim undo files 5d98e9c
Commits on Apr 13, 2011
Felix Geisendörfer version 1.0.0 d07bc76
Felix Geisendörfer Add 1.0 release notes 230d0d3
Felix Geisendörfer Don't use require.paths
node will remove this at some point, let's get rid of it.
Commits on Apr 20, 2011
Dean Landolt deanlandolt update package.json for package refactor 29d5e3f
Commits on Apr 27, 2011
Felix Geisendörfer Merged pull request #68 from deanlandolt/master.
package.json fix
Felix Geisendörfer version 1.0.1 30fcda9
Felix Geisendörfer 1.0.1 Changelog 3f11f39
Felix Geisendörfer Use console.log, not ancient node methods 37b33fc
Commits on May 03, 2011
Felix Geisendörfer Use gitignore instead of npmignore and gitignore 5848319
Felix Geisendörfer Ignore node modules folder 0db3a1f
Commits on May 13, 2011
Felix Geisendörfer Bubble up 'aborted' events from request
Right now those can either mean that the socket had a 'timeout', or 'close'
event before finishing the request. I'll propose a node patch that will allow
seperating the two issues in the future.
Felix Geisendörfer Document 'aborted' event 211cdb9
Commits on May 23, 2011
Felix Geisendörfer Make gently a dev dependency a169691
Felix Geisendörfer Add 1.0.2 changelog 40c475d
Felix Geisendörfer Fix benchmark 3579467
Felix Geisendörfer Fix package.json 8b8da9d
Felix Geisendörfer version 1.0.2 a01d5b4
Felix Geisendörfer Add missing piece to changelog 9c6d710
Felix Geisendörfer Change gitignore to please npm df41df4
Commits on Jun 08, 2011
Jimb Esser Jimbly Fixed example in to be an actual runnable node.js program. 05ad58e
Commits on Jun 09, 2011
Felix Geisendörfer Merge pull request #76 from Jimbly/master
Fix to example code in
Commits on Jun 26, 2011
Logan Kearsley gliese1337 Slight but definite & consistent performance boost. 0a0b150
Commits on Sep 08, 2011
Felix Geisendörfer Move current test suite into test/legacy 50fa2fb
Felix Geisendörfer Run tests using far 75c9ac8
Felix Geisendörfer Add fast-or-slow and new test/common.js 4d07b96
Felix Geisendörfer Merge branch 'fast-or-slow'
* fast-or-slow:
  Add fast-or-slow and new test/common.js
  Run tests using far
  Move current test suite into test/legacy
Commits on Sep 09, 2011
Felix Geisendörfer Add build step 6c528af
Felix Geisendörfer Fix gently version
Newer versions seem to cause an error
Felix Geisendörfer Refactor filename parsing into own function
Will make it easier to write tests
Felix Geisendörfer Add fixtures for filenames with special characters d52ecd3
Felix Geisendörfer Add simple request recorder 93e81d4
Felix Geisendörfer Move new fixtures around b9876eb
Felix Geisendörfer Initial fixture verifier test
Seems to blow up after the first test instead of running all, got to
Felix Geisendörfer Move some code around 4f20c52
Felix Geisendörfer Fix test case bf0ffba
Commits on Sep 10, 2011
Felix Geisendörfer Better filename parsing a3a3a00
Felix Geisendörfer Check fixture part name 2a4f45c
Felix Geisendörfer Validate fixture filenames
Still need to improve parsing
Felix Geisendörfer Unescape quotes for webkit 149353f
Felix Geisendörfer Fix unicode characters in filename for FF / IE 9beddb6
Felix Geisendörfer Merge branch 'gh-94-filenames-with-special-characters'
* gh-94-filenames-with-special-characters:
  Fix unicode characters in filename for FF / IE
  Unescape quotes for webkit
  Validate fixture filenames
  Check fixture part name
  Better filename parsing
  Fix test case
  Move some code around
  Initial fixture verifier test
  Move new fixtures around
  Add simple request recorder
  Add fixtures for filenames with special characters
  Refactor filename parsing into own function

Fixes #58
Fixes #84
Felix Geisendörfer version 1.0.3 55634e9
Felix Geisendörfer 1.0.3 Release notes 0ce4e3f
Felix Geisendörfer Add npmignore efc904f
Commits on Sep 11, 2011
Felix Geisendörfer Fix npm ignore 3559b0c
Commits on Sep 15, 2011
Felix Geisendörfer Plattform independent upload dir detection ed48c81
Felix Geisendörfer Document new uploadDir detection d6b7def
Felix Geisendörfer Merge branch 'gh-88-plattform-independent-upload-dir'
* gh-88-plattform-independent-upload-dir:
  Document new uploadDir detection
  Plattform independent upload dir detection

Fixes #88
Felix Geisendörfer version 1.0.4 6b65348
Felix Geisendörfer Add 1.0.4 changelog 18257ef
Commits on Sep 16, 2011
Felix Geisendörfer Explain unexpected end errors better 2fde202
Felix Geisendörfer Remove http recording left overs from fixtures de9f379
Felix Geisendörfer Support file uploads with filename=""
The new FormData API in Firefox does not support supplying this info yet.
Felix Geisendörfer Add missing test for filenames c5877d3
Felix Geisendörfer version 1.0.5 b2e64e3
Felix Geisendörfer Add 1.0.5 changelog 039f73c
Commits on Sep 19, 2011
Jason Davies jasondavies Fix typos. 1b708e5
Commits on Sep 21, 2011
Felix Geisendörfer Do not give a default filename when filename=""
That's because filename="" is also set when there is an empty file
input field, not just when using mozilla's incomplete FormData APIs.
Felix Geisendörfer version 1.0.6 ee807d5
Felix Geisendörfer 1.0.6 changelog and note on 1.0.5 4721055
Felix Geisendörfer Merge pull request #95 from jasondavies/typos
Fix typos.
Commits on Nov 04, 2011
Felix Geisendörfer Rename funky file
Seems to break this package on windows
Felix Geisendörfer 1.0.7 ba23a96
Commits on Nov 11, 2011
Felix Geisendörfer Add travis build info 7f9b819
Commits on Nov 28, 2011
Felix Geisendörfer Switch to urun for running tests f78a3b6
Felix Geisendörfer Remove fast-or-slow test framework
utest ftw!
Felix Geisendörfer Strip harmful characters when keepExtensions: true
This fixes an issue where a file may be named 'image.jpg?width=200',
and formidable assumed the extension to be '.jpg?width=200' when
using the keepExtensionis: true mode.
Felix Geisendörfer Fix failing legacy test, add new test 1fa9cf7
Felix Geisendörfer Add nerd badge of honor
[ci skip]
Felix Geisendörfer 1.0.8 686ae7d
Felix Geisendörfer Update changelog a37292d
Commits on Dec 24, 2011
Peter Sugihara psugihara switched 'sys' to 'util' in example e39ad65
Commits on Dec 29, 2011
Felix Geisendörfer Merge pull request #118 from ptrsghr/master
Fixed warning in README example
Commits on Jan 13, 2012
goob goob Fix for github's reformatting of #### to use all caps.
Replaced with simple bold text using __ markdown since the double underscore isn't used anywhere else in the document.
Commits on Jan 20, 2012
Felix Geisendörfer Merge pull request #124 from goob/patch-1
Fix for github's reformatting of #### to use all caps.
Commits on Jan 27, 2012
Felix Geisendörfer Improve gitignore for npm 890f033
Commits on Feb 16, 2012
Tim Koschuetzki tim-kos emit progress when content length header parsed 68b4f79
Felix Geisendörfer Merge branch 'emit_progress_when_header_parsed'
Closes #133
Felix Geisendörfer Add v1.0.9 changelog fc67626
Felix Geisendörfer 1.0.9 7fd5c52
Commits on Feb 24, 2012
Felix Geisendörfer Experimental: Integrate new MultipartParser
Passes all tests, so not bad!
Felix Geisendörfer Kinda more professional without console.log a6876d6
Felix Geisendörfer Add mail parsing test 4297d71
Felix Geisendörfer Handle MultipartParser early end errors 39f3be2
Commits on Feb 27, 2012
Felix Geisendörfer Point to right multipart parser version d2dbf14
Felix Geisendörfer Finish mail fixture test b26209f