Maintainer Wanted #412

Open
felixge opened this Issue Jan 11, 2017 · 12 comments

Projects

None yet

5 participants

@felixge
Owner
felixge commented Jan 11, 2017 edited

I haven't maintained this module in a while*, and PRs are piling up.

If anybody is interested in helping out, I'm happy to give commit bits + npm package access.

To get access, please try to write 1-2 sentences that give me a reasonable hope you're not looking to put malicious code into the package and also mention your npm account name.

* For those curious about the "why?", I'm working with Go these days haven't been using node.js for over 3 years now.

@pornel
Collaborator
pornel commented Jan 11, 2017

I'm happy to help a little. I'm using my own fork already: https://github.com/pornel/node-formidable

@felixge
Owner
felixge commented Jan 11, 2017

@pornel sounds good. What's your NPM account? I'll give you access :). Thanks!

@pornel
Collaborator
pornel commented Jan 11, 2017

I'm kornel on npm

@felixge
Owner
felixge commented Jan 13, 2017

@pornel thanks, added you on GH and NPM :).

@ChALkeR done.

@tunnckoCore
Collaborator

i also can help when have time. i have koajs package da uses formidable. it's about 3 years old and many users use it and want it exactly because formidable.

i'm lowercased tunnckocore at npm.

@badeball
Collaborator
badeball commented Jan 13, 2017 edited

Hi, @felixge

I'm happy to help as well. I have decent experience in creating and maintaining libraries, as well as packaging and releasing. @pornel, maybe you want someone to spar with?

@pornel
Collaborator
pornel commented Jan 13, 2017

Sure, the more the merrier.

@felixge
Owner
felixge commented Jan 14, 2017

@tunnckoCore added you on gh and npm.

@badeball added you only on gh since you didn't provide your npm handle.

@ all: Thank you so much for offering your help. I'll leave it up to you if you just want to merge good PRs, or add new features. A lot of people depend on this library, so big API changes are probably undesirable at this point. Anyway, I'll mostly stay out of it, unless you need my help to break a tie on a discussion or similar.

@tunnckoCore
Collaborator
tunnckoCore commented Jan 14, 2017 edited

@felixge cool, thanks!

so big API changes are probably undesirable at this point.

Maybe yea. First we should try to clear the most issues.

We should add some more benchmarks against the other parsers like dicer and busboy, because I'm curious if formidable is still faster.

@felixge
Owner
felixge commented Jan 16, 2017

We should add some more benchmarks against the other parsers like dicer and busboy, because I'm curious if formidable is still faster.

I would expect newer libraries to be faster. I mean I wrote most of the parser 6 years ago, and a lot of things have changed in Node/v8 since then. There was also a lot of time to just improve on my initial ideas :).

Anyway, it would be interesting to see where things are at, but I'd be surprised if formidable wasn't "fast enough" anymore. If it can still process data faster than what your network interface on your server is rated for ... the code is probably fast enough :)

@tunnckoCore
Collaborator

Yea exactly. In any way it is always good to have some comparison to know where we are. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment