Tests should throw deprecation errors #235

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@tim-smart
Collaborator

tim-smart commented Jun 19, 2013

While the library itself will not throw, tests should. Developers should
always avoid deprecat(ed|ing) code / api's.

Signed-off-by: Tim Smart tim@fostle.com

Tests should throw depreciation errors
While the library itself will not throw, tests should. Developers should always
avoid depreciat(ed|ing) code / api's.

Signed-off-by: Tim Smart <tim@fostle.com>
@felixge

This comment has been minimized.

Show comment Hide comment
@felixge

felixge Jun 19, 2013

Owner

Seems to timeout on 0.11?

Owner

felixge commented Jun 19, 2013

Seems to timeout on 0.11?

@OrangeDog

This comment has been minimized.

Show comment Hide comment
@OrangeDog

OrangeDog Jun 19, 2013

Contributor

*deprecated

Contributor

OrangeDog commented Jun 19, 2013

*deprecated

@tim-smart

This comment has been minimized.

Show comment Hide comment
@tim-smart

tim-smart Jun 19, 2013

Collaborator

It seems current master is timing out on latest node. There was a regression in the writable file stream with finish events.

Collaborator

tim-smart commented Jun 19, 2013

It seems current master is timing out on latest node. There was a regression in the writable file stream with finish events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment