Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buffer.write order of arguments #404

Merged
merged 1 commit into from Jan 13, 2017

Conversation

kornelski
Copy link
Contributor

Node 7 throws on

Buffer.write(string, encoding, offset[, length]) is no longer supported

the order of arguments has changed.

mikeatlas added a commit to mikeatlas/meteor-tomi-upload-server that referenced this pull request Jan 10, 2017
Hi - there's a newer (but not very new) update to Formidable which contains a fix to support Node 6.x:

node-formidable/formidable@f4a3e08
node-formidable/formidable#364
node-formidable/formidable#404
mikeatlas added a commit to mikeatlas/meteor-tomi-upload-server that referenced this pull request Jan 10, 2017
Hi - there's a newer (but not very new) update to Formidable which contains a fix to support Node 6.x:

node-formidable/formidable@f4a3e08
node-formidable/formidable#364
node-formidable/formidable#404
@felixge
Copy link
Collaborator

felixge commented Jan 11, 2017

See #412

@kornelski kornelski merged commit ee986ef into node-formidable:master Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants