Permalink
Browse files

Remove public info function

  • Loading branch information...
1 parent b259b30 commit 856171532fea5c8ed52dc50c02d0df88b6b6c9da @felixge committed Apr 11, 2011
Showing with 5 additions and 7 deletions.
  1. +0 −1 Readme.md
  2. +2 −2 lib/writer/extended_writer.js
  3. +2 −2 test/fixture/extended_writer.m3u8
  4. +1 −2 test/integration/test-extended-writer.js
View
1 Readme.md
@@ -90,7 +90,6 @@ well as additional capabilities defined by Apple:
Things I'm working on:
* npm package
-* Remove info() function
## Contributing
View
4 lib/writer/extended_writer.js
@@ -7,7 +7,7 @@ function ExtendedWriter(properties) {
oop.extend(ExtendedWriter, Writer);
module.exports = ExtendedWriter;
-ExtendedWriter.prototype.info = function(duration, title) {
+ExtendedWriter.prototype._info = function(duration, title) {
if (title === undefined) {
title = '';
}
@@ -17,7 +17,7 @@ ExtendedWriter.prototype.info = function(duration, title) {
ExtendedWriter.prototype.file = function(uri, duration, title) {
if (arguments.length > 1) {
- this.info(duration, title);
+ this._info(duration, title);
}
Writer.prototype.file.call(this, uri);
View
4 test/fixture/extended_writer.m3u8
@@ -1,7 +1,7 @@
#EXTM3U
#I am a comment
-#EXTINF:10,Artist - Title
-#EXTINF:42,
foo.mp3
#EXTINF:23,
bar.mp3
+#EXTINF:10,Artist - Title
+last.mp3
View
3 test/integration/test-extended-writer.js
@@ -4,9 +4,8 @@ var fixture = common.helper.fixture;
var writer = common.m3u.extendedWriter();
writer.comment('I am a comment');
-writer.info('10', 'Artist - Title');
-writer.info('42');
writer.file('foo.mp3');
writer.file('bar.mp3', 23);
+writer.file('last.mp3', 10, 'Artist - Title');
fixture.compare(writer, 'extended_writer.m3u8');

0 comments on commit 8561715

Please sign in to comment.