Add About page to the settings window #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on suggestions by @felixse
This seems to solve display issues when opening the "About" page multiple times where the main navigation list is being rerendered for no apparent reason.
felixse
requested changes
Oct 27, 2018
|
Looks good, thank you very much 👍 If you need any help with my comments just write me |
|
Thanks for extending the hamburger menu 😊 |
felixse
approved these changes
Oct 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #98
Architectural changes
I moved the
UpdateServiceandNotificationServiceservice to the App.Services package(?) and created interfaces for them as well. This resulted in the following changes:Checking for updates
As a consequence I moved the check for updates to `App.xaml.cs` which may have some unwanted consequences: 1) not checked for updates if the main/terminal window is not opened at startup, and 2) now checks for updates whenever a new main/terminal window (or tab?) is opened. However, I think it is possible to revert this change 🤔NotificationService
I'm not sure how C# handles this, but note that the `NotificationService` is in both `App.xaml.cs` and `Program.cs`, I'm not sure what consequences this has...Code style notes
About.xamland I noticed the existing code base had no comments for the page layout filesnew Version(0, 0, 0, 0);if it can't find the latest version onlineThe data for the About page is loaded in the Page class rather then the ViewModel (the reason for this is that I had trouble getting the page to show the asynchronously loaded latest version)Resolved with db01c51Miscellaneous notes
Segoe MDL2 Assetsrather then the custom font-file included in the project<PackageReference>s inFluentTerminal.App.Services.csproj, but this was the only way I got things working 😅Assets/AppIconsfolder for the About page, but I'm not sure if that is the correct location for it 🤔SettingsPage.xaml.csto make sure the tab indicator in the settings view works correctly when the about page shows, you can read more hereHamburger menu
As already mentioned in #98 I did not manage to add a working menu item to the hamburger menu in the main/terminal window. You can find the code for my attempt right hereResolved with c4a04bc