New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press enter to close an InputDialog #177

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
2 participants
@ericcornelissen
Copy link
Contributor

ericcornelissen commented Jan 16, 2019

... As if the primary button is pressed.

Closes #174 (the original request)

Implementation

I did not figure out how to have result be equal to ContentDialogResult.Primary (as seen here) so I used an internal variable to communicate the intent of closing the dialog.

Press enter to close an Input dialog
... As if the primary button is pressed.

@felixse felixse merged commit 369b5dd into felixse:master Jan 18, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@felixse

This comment has been minimized.

Copy link
Owner

felixse commented Jan 18, 2019

Thanks 👍

@ericcornelissen ericcornelissen deleted the ericcornelissen:close-changetitle-on-enter branch Jan 19, 2019

Riebart added a commit to Riebart/FluentTerminal that referenced this pull request Feb 12, 2019

Press enter to close an Input dialog (felixse#177)
... As if the primary button is pressed.

felixse added a commit that referenced this pull request Feb 13, 2019

Line ending translation (#172)
* On paste, the TerminalViewModel uses the ShellProfile to translate line endings.

Default line ending translation style is set to not modify the pasted contents, Next up, adding the radio button to shell profile.

* Added UI elements for choosing line ending style.

Using a converter to map between an enum and radio buttons, and another converter to map from enum to text based on the description of the enum value.

* Added "Paste without newlines" command.

* Adding missing converters to project file.

* A few fixes after cherry-picks.

* Adding missing Command property to PasteWithoutNewlines keybinding.

* Cleaned up some unnecessary property settings.

* fix #114 scrolling issue on presicion touchpads (#171)

* fix #114 scrolling issue on presicion touchpads, bounce scroll & pinch zoom

* rephrased comment

* removed css that enforced autohiding

* simplified js code handling scrollbar size

* Press enter to close an Input dialog (#177)

... As if the primary button is pressed.

* Renew certificate

* Update README.md

* Add option to use bold text in terminals (#183)

* Add option to use bold text in terminals

... as per #182

* Add BoldText to setting defaults

* Remove AppVeyor files

* Update README.md

* Add keybinding to change the (current) tab title (#193)

* Add keybinding for change the (current) tab title

Default binding is Ctrl+Shift+N

* Update change tab title default keybind to Ctrl+Shift+R

* Experimental ConPTY support (#199)

* First steps of ConPty support

* Added resize functionality

* fix cwd, args, hide console window

* Handle shell process exited

* Make ConPTY optional

* Fix automerge errors

* Accepted many XAML formatting changes, and changed command handling to switch.

* Fixed spaxcng on the settings page.

* adapted radio button binding to be in line with the rest of the application
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment