Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd option to use bold text in terminals #183
Conversation
ericcornelissen
referenced this pull request
Jan 24, 2019
Closed
Allow bold text for prompts etc #182
ericcornelissen
added some commits
Jan 26, 2019
ericcornelissen
force-pushed the
ericcornelissen:terminal/bold-text
branch
from
729437f
to
0d50770
Jan 26, 2019
This comment has been minimized.
This comment has been minimized.
The build failure seems to be caused by the certificate being invalid, the same is true for the latest build on master even though the certificate was updated in that commit for #185 |
This comment has been minimized.
This comment has been minimized.
That's my fault. The CI is using some encrypted certificates I should also have updated, but my plan is to migrate the CI to Azure Pipelines in the next days. |
felixse
approved these changes
Jan 28, 2019
felixse
merged commit 90f15cc
into
felixse:master
Jan 28, 2019
1 check failed
continuous-integration/appveyor/pr
AppVeyor build failed
Details
ericcornelissen
deleted the
ericcornelissen:terminal/bold-text
branch
Jan 28, 2019
added a commit
to ericcornelissen/portfolio
that referenced
this pull request
Jan 28, 2019
added a commit
to Riebart/FluentTerminal
that referenced
this pull request
Feb 12, 2019
added a commit
that referenced
this pull request
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ericcornelissen commentedJan 20, 2019
•
edited
Closes #182
Adds a toggle to the Terminal Page to enable/disable bold text in terminals. Currently, from my testing, when
BoldText
is enabled there is no real distinction between normal and bold text in most fonts, I also addressed this in this comment.Alternative implementation
Currently the conversion from boolean to⬇️ , but this seems like overkill to me.
fontWeight
andfontWeightBold
value is performed 2x each, alternatively we could use transformer functions, e.g.