New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use bold text in terminals #183

Merged
merged 3 commits into from Jan 28, 2019

Conversation

Projects
None yet
2 participants
@ericcornelissen
Copy link
Contributor

ericcornelissen commented Jan 20, 2019

Closes #182

Adds a toggle to the Terminal Page to enable/disable bold text in terminals. Currently, from my testing, when BoldText is enabled there is no real distinction between normal and bold text in most fonts, I also addressed this in this comment.

Alternative implementation

Currently the conversion from boolean to fontWeight and fontWeightBold value is performed 2x each, alternatively we could use transformer functions, e.g. ⬇️, but this seems like overkill to me.

term.setOption('fontWeight', boldToFontWeight(options.boldText));
term.setOption('fontWeightBold', boldToFontWeightBold(options.boldText));

...

function boldToFontWeight(boldText) {
  return options.boldText ? 'bold' : 'normal';
}
function boldToFontWeightBold(boldText) {
  return options.boldText ? 'bolder' : 'bold';
}

@ericcornelissen ericcornelissen force-pushed the ericcornelissen:terminal/bold-text branch from 729437f to 0d50770 Jan 26, 2019

@ericcornelissen

This comment has been minimized.

Copy link
Contributor Author

ericcornelissen commented Jan 28, 2019

The build failure seems to be caused by the certificate being invalid, the same is true for the latest build on master even though the certificate was updated in that commit for #185 🤔

@felixse

This comment has been minimized.

Copy link
Owner

felixse commented Jan 28, 2019

That's my fault. The CI is using some encrypted certificates I should also have updated, but my plan is to migrate the CI to Azure Pipelines in the next days.

@felixse felixse merged commit 90f15cc into felixse:master Jan 28, 2019

1 check failed

continuous-integration/appveyor/pr AppVeyor build failed
Details

@ericcornelissen ericcornelissen deleted the ericcornelissen:terminal/bold-text branch Jan 28, 2019

ericcornelissen added a commit to ericcornelissen/portfolio that referenced this pull request Jan 28, 2019

@felixse felixse referenced this pull request Jan 31, 2019

Closed

Font weight #109

Riebart added a commit to Riebart/FluentTerminal that referenced this pull request Feb 12, 2019

Add option to use bold text in terminals (felixse#183)
* Add option to use bold text in terminals

... as per felixse#182

* Add BoldText to setting defaults

felixse added a commit that referenced this pull request Feb 13, 2019

Line ending translation (#172)
* On paste, the TerminalViewModel uses the ShellProfile to translate line endings.

Default line ending translation style is set to not modify the pasted contents, Next up, adding the radio button to shell profile.

* Added UI elements for choosing line ending style.

Using a converter to map between an enum and radio buttons, and another converter to map from enum to text based on the description of the enum value.

* Added "Paste without newlines" command.

* Adding missing converters to project file.

* A few fixes after cherry-picks.

* Adding missing Command property to PasteWithoutNewlines keybinding.

* Cleaned up some unnecessary property settings.

* fix #114 scrolling issue on presicion touchpads (#171)

* fix #114 scrolling issue on presicion touchpads, bounce scroll & pinch zoom

* rephrased comment

* removed css that enforced autohiding

* simplified js code handling scrollbar size

* Press enter to close an Input dialog (#177)

... As if the primary button is pressed.

* Renew certificate

* Update README.md

* Add option to use bold text in terminals (#183)

* Add option to use bold text in terminals

... as per #182

* Add BoldText to setting defaults

* Remove AppVeyor files

* Update README.md

* Add keybinding to change the (current) tab title (#193)

* Add keybinding for change the (current) tab title

Default binding is Ctrl+Shift+N

* Update change tab title default keybind to Ctrl+Shift+R

* Experimental ConPTY support (#199)

* First steps of ConPty support

* Added resize functionality

* fix cwd, args, hide console window

* Handle shell process exited

* Make ConPTY optional

* Fix automerge errors

* Accepted many XAML formatting changes, and changed command handling to switch.

* Fixed spaxcng on the settings page.

* adapted radio button binding to be in line with the rest of the application
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment