Add keybinding to change the (current) tab title #193
I don't think we should use Ctrl+Shift+N as a default keybinding. Right now, we use Ctrl+T for a new tab, Ctrl+Shift+T for a configurable new tab, and Ctrl+N for a new window. Logic dictates that we should have Ctrl+Shift+N give us a new configurable window. (This functionality doesn't exist today, but it should probably be added.) Can we instead use something like Ctrl+Shift+R (R for "Rename")?…
-- Hans Kokx On 2/3/2019 2:19:36 PM, Eric Cornelissen <firstname.lastname@example.org> wrote: As per the suggestion [#174 (comment)] by @ChristianSauer [https://github.com/ChristianSauer]. I set the default binding to Ctrl+Shift+N. You can view, comment on, or merge this pull request online at: #193 [#193] Commit Summary * Add keybinding for change the (current) tab title File Changes * M FluentTerminal.App.Services/Implementation/DefaultValueProvider.cs [https://github.com/felixse/FluentTerminal/pull/193/files#diff-0] (13) * M FluentTerminal.App.ViewModels/MainViewModel.cs [https://github.com/felixse/FluentTerminal/pull/193/files#diff-1] (1) * M FluentTerminal.App.ViewModels/TerminalViewModel.cs [https://github.com/felixse/FluentTerminal/pull/193/files#diff-2] (18) * M FluentTerminal.Models/Enums/Command.cs [https://github.com/felixse/FluentTerminal/pull/193/files#diff-3] (3) * M FluentTerminal.Models/KeyBindings.cs [https://github.com/felixse/FluentTerminal/pull/193/files#diff-4] (1) Patch Links: * https://github.com/felixse/FluentTerminal/pull/193.patch [https://github.com/felixse/FluentTerminal/pull/193.patch] * https://github.com/felixse/FluentTerminal/pull/193.diff [https://github.com/felixse/FluentTerminal/pull/193.diff] — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub [#193], or mute the thread [https://github.com/notifications/unsubscribe-auth/AB0sbycRUmFbzmU2lw2NX917e6Dtnf6cks5vJzZHgaJpZM4agQ9M].
Riebart added a commit to Riebart/FluentTerminal that referenced this pull request
Feb 12, 2019
* Add keybinding for change the (current) tab title Default binding is Ctrl+Shift+N * Update change tab title default keybind to Ctrl+Shift+R
felixse added a commit that referenced this pull request
Feb 13, 2019
* On paste, the TerminalViewModel uses the ShellProfile to translate line endings. Default line ending translation style is set to not modify the pasted contents, Next up, adding the radio button to shell profile. * Added UI elements for choosing line ending style. Using a converter to map between an enum and radio buttons, and another converter to map from enum to text based on the description of the enum value. * Added "Paste without newlines" command. * Adding missing converters to project file. * A few fixes after cherry-picks. * Adding missing Command property to PasteWithoutNewlines keybinding. * Cleaned up some unnecessary property settings. * fix #114 scrolling issue on presicion touchpads (#171) * fix #114 scrolling issue on presicion touchpads, bounce scroll & pinch zoom * rephrased comment * removed css that enforced autohiding * simplified js code handling scrollbar size * Press enter to close an Input dialog (#177) ... As if the primary button is pressed. * Renew certificate * Update README.md * Add option to use bold text in terminals (#183) * Add option to use bold text in terminals ... as per #182 * Add BoldText to setting defaults * Remove AppVeyor files * Update README.md * Add keybinding to change the (current) tab title (#193) * Add keybinding for change the (current) tab title Default binding is Ctrl+Shift+N * Update change tab title default keybind to Ctrl+Shift+R * Experimental ConPTY support (#199) * First steps of ConPty support * Added resize functionality * fix cwd, args, hide console window * Handle shell process exited * Make ConPTY optional * Fix automerge errors * Accepted many XAML formatting changes, and changed command handling to switch. * Fixed spaxcng on the settings page. * adapted radio button binding to be in line with the rest of the application
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.