Add keybinding for configurable new window #216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #96 and this comment I added a keybinding to open a new configurable window. The default binding is Ctrl+Shift+N.
Alternative design
1] It may be possible to rely less on a parameter (
showProfileSelection
) in App.xaml.cs, but I personally don't think that's a good idea.2] There are now two
EventArgs
(namelyCancelableEventArgs
andProfileSelectEventArgs
) that basically only hold a boolean value (cancelled
andShowProfileSelection
respectively). On the one hand one the naming helps the reader understand the code, on the other hand it you have (albeit simple) duplicate code. I can refactor theEventArgs
into a singleBooleanEventArgs
class like so:However, the current approach forces the programmer to be descriptive, whereas the refactor would allow misuse of the
EventArgs
, like so: