Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom context menu for single tab layout #224

Merged
merged 4 commits into from Mar 10, 2019

Conversation

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Mar 8, 2019

Closes #178

The implementation is pretty straightforward. The context menu code comes from TabBar.xaml adjusted for the context of MainPage.xaml. I omitted the Close option from the list as closing the only tab by itself makes no sense.

I'm not sure about the change in c912592, in my experience it works just fine but maybe I missed something...

single-tab-context-menu-preview

@felixse felixse merged commit 57d86a9 into felixse:master Mar 10, 2019
@ericcornelissen ericcornelissen deleted the ericcornelissen:single-tab-context-menu branch Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.