Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd custom context menu for single tab layout #224
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ericcornelissen commentedMar 8, 2019
Closes #178
The implementation is pretty straightforward. The context menu code comes from
TabBar.xamladjusted for the context ofMainPage.xaml. I omitted theCloseoption from the list as closing the only tab by itself makes no sense.I'm not sure about the change in c912592, in my experience it works just fine but maybe I missed something...