Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for "Transfer-Encoding" header occasionally returned in lower-case #63
Conversation
added a commit
that referenced
this pull request
Apr 22, 2014
DarrenCook
merged commit 408d782
into
fennb:master
Apr 22, 2014
This comment has been minimized.
This comment has been minimized.
andyyoung
commented
Apr 22, 2014
|
|
This comment has been minimized.
This comment has been minimized.
joetek
commented
Apr 23, 2014
|
Thanks for the quick fix! |
This comment has been minimized.
This comment has been minimized.
|
Yup, thanks heaps for the very fast fix! |
This comment has been minimized.
This comment has been minimized.
AndresJ551
commented on 1558e18
Apr 24, 2014
|
Thanks for fixing this! |
This comment has been minimized.
This comment has been minimized.
|
Yes, thank you! This reminds me that the HTTP spec does not require case-sensitivity for headers, so we probably should use |
This comment has been minimized.
This comment has been minimized.
rickumali
replied
Apr 25, 2014
|
Thanks @fennb ! This fix helped me out. |
This comment has been minimized.
This comment has been minimized.
|
@rickumali Don't thank me, thank @hootphil ! |
This comment has been minimized.
This comment has been minimized.
rickumali
replied
Apr 28, 2014
|
Hi @hootphil, thanks for this fix! |
This comment has been minimized.
This comment has been minimized.
fubar
commented
Apr 26, 2014
|
You're right @fennb, HTTP header field names are case-insensitive indeed. See https://dev.twitter.com/discussions/27837#comment-63086 |
fubar commentedApr 22, 2014
Relatively rarely, connecting to the Streaming API at https://stream.twitter.com/1.1/statuses/filter returns the "Transfer-Encoding" header in lower-case: "transfer-encoding: chunked". This currently triggers the Exception "Twitter did not send a chunking header. Is this really HTTP/1.1? (...)" (line 745).
I've opened a discussion on the Twitter dev site for this bug (currently awaiting moderation): https://dev.twitter.com/discussions/27837
Whether they can resolve it or not, it doesn't hurt to tolerate the lower-case version.