Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optim #104

Merged
merged 60 commits into from Feb 23, 2019

Conversation

Projects
None yet
1 participant
@fennecdjay
Copy link
Owner

fennecdjay commented Feb 8, 2019

Using computed gotos, fixing dynamicity.

fennecdjay added some commits Jan 25, 2019

@todo

This comment has been minimized.

Copy link

todo bot commented Feb 8, 2019

improve me

Gwion/src/emit/emit.c

Lines 1449 to 1454 in 1a1d163

// TODO: improve me
const Instr func_i = emit_add_instr(emit, PushStaticCode);
func_i->m_val = (m_uint)func;
// }
return GW_OK;
}


This comment was generated by todo based on a TODO comment in 1a1d163 in #104. cc @fennecdjay.
@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 14, 2019

This pull request introduces 1 alert when merging d37335e into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Use of goto

Comment posted by LGTM.com

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 15, 2019

This pull request introduces 1 alert when merging 54b98a4 into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Use of goto

Comment posted by LGTM.com

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 15, 2019

This pull request introduces 2 alerts when merging 2096e78 into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter
  • 1 for Use of goto

Comment posted by LGTM.com

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 21, 2019

This pull request introduces 2 alerts when merging a06ee3e into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter
  • 1 for Use of goto

Comment posted by LGTM.com

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 21, 2019

This pull request introduces 2 alerts when merging 3b3eae4 into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter
  • 1 for Use of goto

Comment posted by LGTM.com

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 22, 2019

This pull request introduces 2 alerts when merging dd68a11 into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter
  • 1 for Use of goto

Comment posted by LGTM.com

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 22, 2019

This pull request introduces 2 alerts when merging 1630cfd into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter
  • 1 for Use of goto

Comment posted by LGTM.com

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 22, 2019

This pull request introduces 2 alerts when merging 24c6db5 into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter
  • 1 for Use of goto

Comment posted by LGTM.com

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 22, 2019

This pull request introduces 2 alerts when merging f3960e4 into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter
  • 1 for Use of goto

Comment posted by LGTM.com

fennecdjay added some commits Feb 22, 2019

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 22, 2019

This pull request introduces 2 alerts when merging a89005c into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter
  • 1 for Use of goto

Comment posted by LGTM.com

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 22, 2019

This pull request introduces 2 alerts when merging 1d6d8f4 into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter
  • 1 for Use of goto

Comment posted by LGTM.com

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 23, 2019

This pull request introduces 2 alerts when merging ce5f9fb into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter
  • 1 for Use of goto

Comment posted by LGTM.com

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 23, 2019

This pull request introduces 2 alerts when merging c3b73f5 into b8ca5c8 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter
  • 1 for Use of goto

Comment posted by LGTM.com

@fennecdjay

This comment has been minimized.

Copy link
Owner Author

fennecdjay commented Feb 23, 2019

🎉
A big pull Request.

  • new VM, 3x faster
  • fix dinamicity
    and other fixes...
    😄

@fennecdjay fennecdjay merged commit d8884a1 into master Feb 23, 2019

3 of 4 checks passed

Better Code Hub ⚠️️ You lost 2 guidelines
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ 2 new alerts
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fennecdjay fennecdjay deleted the optim branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.