Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add single header magic #114

Merged
merged 2 commits into from May 14, 2019

Conversation

Projects
None yet
2 participants
@scalarwaves
Copy link
Contributor

commented May 14, 2019

Pertaining to #112 This header is a start for binding to other languages.

Having all core header files in one place makes importing the library version of Gwion much simpler.

Based on this gist by fennecdjay.

@fennecdjay

This comment has been minimized.

Copy link
Owner

commented May 14, 2019

Nice! 🍾
I'm a bit worried with the ../ thing thought.
Can't you use something like -I../ast/include -I../util/include ?
It would save us the ../ and gain some flexibility.

@scalarwaves

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

Your solution is more elegant, I returned it to its original state.

@fennecdjay

This comment has been minimized.

Copy link
Owner

commented May 14, 2019

Looking Good!
Is there anything you want to add for this particular PR?
If not I'll merge as soon as the test succeed (wondering why travis is not showing up).

Does it mean you had some success with codegen?


EDIT: probably got travis back.

@fennecdjay

This comment has been minimized.

Copy link
Owner

commented May 14, 2019

Looks Good! Merging 🍾
Thank you @scalarwaves.

@fennecdjay fennecdjay merged commit a33c22d into fennecdjay:master May 14, 2019

3 checks passed

Better Code Hub ✅ Better Code Hub approves this code
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.