Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update var to es6 #325

Merged
merged 2 commits into from Jun 6, 2018
Merged

update var to es6 #325

merged 2 commits into from Jun 6, 2018

Conversation

rubs019
Copy link
Contributor

@rubs019 rubs019 commented Jun 5, 2018

#324 PR of discussion

@codecov
Copy link

codecov bot commented Jun 5, 2018

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #325   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         595    594    -1     
  Branches      149    149           
=====================================
- Hits          595    594    -1
Impacted Files Coverage Δ
lib/index.js 100% <100%> (ø) ⬆️
lib/util.js 100% <100%> (ø) ⬆️
lib/sig.js 100% <100%> (ø) ⬆️
lib/info.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6c60b5...74fc916. Read the comment docs.

@fent
Copy link
Owner

fent commented Jun 5, 2018

Cool! Do you mind doing this for files in the test and example folders too? I'd rather handle this change all at once

One more thing, a .DS_Store file was added to this PR, please remove.

@rubs019 rubs019 force-pushed the master branch 2 times, most recently from 2e6727c to b1c4528 Compare June 6, 2018 11:39
@rubs019
Copy link
Contributor Author

rubs019 commented Jun 6, 2018

Yes I can do it
For the .DS_Store I just create a new commit and add DS_Store && .idea in gitignore

Let me know if it's ok for you

@fent fent merged commit e057c19 into fent:master Jun 6, 2018
@fent
Copy link
Owner

fent commented Jun 6, 2018

Thanks for taking the time for this, even though it was probably tedious

@rubs019
Copy link
Contributor Author

rubs019 commented Jun 6, 2018

No probs, this is my first contribution on an open-source project. I chose something easy and necessary in a certain way ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants