Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pyO3 to 0.18 #119

Merged
merged 7 commits into from
Jan 24, 2023
Merged

Update pyO3 to 0.18 #119

merged 7 commits into from
Jan 24, 2023

Conversation

g-bauer
Copy link
Contributor

@g-bauer g-bauer commented Jan 20, 2023 •
edited
Loading

  • feos-core
  • feos-dft
  • feos-derive
  • feos

@prehner prehner added python Python related feature or issue DFT DFT related feature or issue core related to features in feos-core labels Jan 20, 2023
@g-bauer g-bauer added this to the v0.4.0 milestone Jan 23, 2023
@g-bauer g-bauer marked this pull request as ready for review January 23, 2023 14:51
@g-bauer g-bauer requested a review from prehner January 23, 2023 14:51
prehner
prehner reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@prehner prehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Some things are much clearer and also more easily maintainable for the future.

CHANGELOG.md Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
feos-core/src/python/parameter.rs Show resolved Hide resolved
src/association/python.rs Show resolved Hide resolved
src/gc_pcsaft/python/mod.rs Show resolved Hide resolved
src/python/dft.rs Show resolved Hide resolved
@g-bauer g-bauer merged commit b5ea3b7 into main Jan 24, 2023
@g-bauer g-bauer deleted the update_pyo3_0.18.0 branch January 24, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prehner prehner prehner approved these changes

Assignees
No one assigned
Labels
core related to features in feos-core DFT DFT related feature or issue python Python related feature or issue
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@g-bauer @prehner