Support the new logger interface #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes are backwards compatible, but will be blocking for rebar3 since logger uses maps and that means R16 is no longer supported. Logger's default handler is muted through a filter, and a new handler is added there with a different name. The same event handler that was used to add data to error_logger is used, and expanded for logger support as well. This seems to make everything work as expected.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are backwards compatible, but will be blocking for rebar3
since logger uses maps and that means R16 is no longer supported.
Logger's default handler is muted through a filter, and a new handler is
added there with a different name. The same event handler that was used
to add data to error_logger is used, and expanded for logger support as
well.
This seems to make everything work as expected.