New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions about the arm64 modifications #1

Closed
zhuowei opened this Issue Jul 25, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@zhuowei
Copy link

zhuowei commented Jul 25, 2018

Thanks for your hard work in getting xnu to compile. I have a few questions:

  • Why specifically define -DARM64_BOARD_CONFIG_T8011?

It might be better to use -DARM64_BOARD_CONFIG_$(CURRENT_MACHINE_CONFIG) instead and populate the SUPPORTED_ARM64_MACHINE_CONFIGS, so that one can specify the board to build from the make command by running make TARGET_CONFIGS="DEBUG ARM64 T8011".

  • Where is the "correct" place to define CONFIG_EMBEDDED anyways? Should it go in config/MASTER instead?

config/MASTER.arm64 specifies config_embedded, but there's no corresponding option in config/MASTER. I tried adding

options CONFIG_EMBEDDED # <config_embedded>

and that did define CONFIG_EMBEDDED for arm64.

  • I saw that you're one of the two repositories on Github that's trying to build Apple's arm64 xnu. Have you considered helping out the RaspberryPi-XNU project?
@fergofrog

This comment has been minimized.

Copy link
Owner

fergofrog commented Jul 28, 2018

Thanks for the great ideas @zhuowei. I've given an attempt at implementing the first two points in commit 2c9da45. I really like the idea of using the MACHINE_CONFIG to specify the target board. Let me know what you think and I'll merge it in and update the blog post.

For the last point, for me this repo is so I could get a working compile_commands.json to work with Woboq, as well as be able to do some analysis with the AST. I'm not hoping to run it on a real device. Certainly trying to get all the MSR's and device trees set up is more work than I'm up for with my spare time.

fergofrog added a commit that referenced this issue Dec 23, 2018

@fergofrog fergofrog closed this Dec 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment