-
Notifications
You must be signed in to change notification settings - Fork 76
Feat/multitab blocks #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/multitab blocks #239
Conversation
@karthik2804 this is a great addition! I added a separate issue #240 to raise the question of how best we could document how the formatting you outlined here (thanks for the example!) can be published for the developer who is writing & editing pages, it's not a blocker for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only approving the description and example. I have not tested the code, nor read it. Consider adding a reviewer to review the JS code.
@karthik2804 I've reviewed the JS changes and it LGTM! In |
9aa9a25
to
713a100
Compare
Signed-off-by: karthik Ganeshram <karthik.ganeshram@fermyon.com>
Signed-off-by: flynnduism <ronan@fermyon.com> Signed-off-by: karthik Ganeshram <karthik.ganeshram@fermyon.com>
Signed-off-by: flynnduism <ronan@fermyon.com> Signed-off-by: karthik Ganeshram <karthik.ganeshram@fermyon.com>
Signed-off-by: flynnduism <ronan@fermyon.com> Signed-off-by: karthik Ganeshram <karthik.ganeshram@fermyon.com>
Signed-off-by: karthik Ganeshram <karthik.ganeshram@fermyon.com>
713a100
to
be9b87c
Compare
Signed-off-by: karthik Ganeshram <karthik.ganeshram@fermyon.com>
This PR also includes the refactoring of the javascript into multiple files for easier maintenance.
Shortcodes need to be enabled in the frontmatter to use multitab.
The markup to create tabs in markdown is as follows