Skip to content

chore(seed): add api-wide-base-path-with-default to allowedFailures for csharp-sdk#16014

Merged
Swimburger merged 1 commit into
mainfrom
devin/1779297893-add-base-path-allowed-failures
May 20, 2026
Merged

chore(seed): add api-wide-base-path-with-default to allowedFailures for csharp-sdk#16014
Swimburger merged 1 commit into
mainfrom
devin/1779297893-add-base-path-allowed-failures

Conversation

@Swimburger
Copy link
Copy Markdown
Member

@Swimburger Swimburger commented May 20, 2026

Description

The new api-wide-base-path-with-default fixture introduced in #15998 causes seed test failures for csharp-sdk. This adds the fixture to allowedFailures until the generator supports the new feature.

Note: php-sdk was already fixed on main via #16006.

Changes Made

  • Added api-wide-base-path-with-default to allowedFailures in seed/csharp-sdk/seed.yml

Testing

Link to Devin session: https://app.devin.ai/sessions/eae9060efee04cb49d8451238ffd1ce9
Requested by: @Swimburger

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

…or php-sdk and csharp-sdk

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration devin-ai-integration Bot force-pushed the devin/1779297893-add-base-path-allowed-failures branch from d1e4254 to 923fdff Compare May 20, 2026 18:16
@devin-ai-integration devin-ai-integration Bot changed the title chore(seed): add api-wide-base-path-with-default to allowedFailures for php-sdk and csharp-sdk chore(seed): add api-wide-base-path-with-default to allowedFailures for csharp-sdk May 20, 2026
@Swimburger Swimburger merged commit 6768aea into main May 20, 2026
57 checks passed
@Swimburger Swimburger deleted the devin/1779297893-add-base-path-allowed-failures branch May 20, 2026 18:21
@github-actions
Copy link
Copy Markdown
Contributor

SDK Generation Benchmark Results

Comparing PR branch against median of 5 nightly run(s) on main (latest: 2026-05-20T05:20:23Z).

Full benchmark table (click to expand)
Generator Spec main (generator) main (E2E) PR (generator) Delta
csharp-sdk square 67s (n=5) 105s (n=5) 61s -6s (-9.0%)

main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via fern generate). main (E2E): full customer-observable time including build/test scripts (nightly baseline, informational). Delta is computed against generator-only baseline.
⚠️ = generation exited with a non-zero exit code (timing may not reflect a successful run).
Baseline from nightly runs on main (latest: 2026-05-20T05:20:23Z). Trigger benchmark-baseline to refresh.
Last updated: 2026-05-20 20:12 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant