Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ws to next major version (when it's released) #92

Closed
feross opened this issue Aug 30, 2015 · 6 comments
Closed

Update ws to next major version (when it's released) #92

feross opened this issue Aug 30, 2015 · 6 comments
Labels

Comments

@feross
Copy link
Member

feross commented Aug 30, 2015

Because of issues like this one: mafintosh/torrent-stream#137 (comment)

@feross
Copy link
Member Author

feross commented Aug 30, 2015

Another reason to get rid of this dep is that on an OS X machine with the command line tools installed, but no Xcode, this error is spewed upon installing WebTorrent:

npm WARN engine windows-no-runnable@0.0.6: wanted: {"node":"0.6"} (current: {"node":"0.12.7","npm":"2.11.3"})

> bufferutil@1.1.0 install /usr/local/lib/node_modules/webtorrent/node_modules/torrent-discovery/node_modules/bittorrent-tracker/node_modules/ws/node_modules/bufferutil
> node-gyp rebuild

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
  SOLINK_MODULE(target) Release/bufferutil.node

> utf-8-validate@1.1.0 install /usr/local/lib/node_modules/webtorrent/node_modules/torrent-discovery/node_modules/bittorrent-tracker/node_modules/ws/node_modules/utf-8-validate
> node-gyp rebuild

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

  CXX(target) Release/obj.target/validation/src/validation.o
  SOLINK_MODULE(target) Release/validation.node

@No9
Copy link

No9 commented Aug 31, 2015

+1 for removing as many native deps as possible

@mafintosh
Copy link
Contributor

We could PR the two native deps to switch to prebuild and then add have them fallback to the js libraries if no prebuild is available

@feross
Copy link
Member Author

feross commented Sep 8, 2015

websockets/ws#577

@feross
Copy link
Member Author

feross commented Dec 28, 2015

The ws package just removed its native dependencies, so as soon as they publish that to npm, we can bump the version here and this will no longer be an issue!

websockets/ws@49b1109

@feross feross changed the title Remove dependency on ws Update ws to next major version (when it's released) Dec 28, 2015
@feross feross added the bug label Dec 28, 2015
@feross
Copy link
Member Author

feross commented Jan 3, 2016

This is done, released as 7.0.0.

@feross feross closed this as completed Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants