Consider matching Buffer.toJSON() more closely

[humphd]

> var buf = new Buffer([1,2,3])
> buf.toJSON()
[ 1, 2, 3 ]

With buffer in the browser I get {type: 'Buffer', data: [...]}. Obviously you're doing this intentionally, since the code does exactly this. However, I wonder why you've chosen to do it this way? At the very least, documenting the difference will save users problems when it works differently than they expect.

[feross]

Actually, this is how buffer.toJSON() works in node 0.11 which this module
is tracking.

0.11 also made some other changes including adding buffer.equal(),
buffer.compare(), buffer.toArrayBuffer() which are also available in this
module.

On Thursday, July 10, 2014, David Humphrey notifications@github.com wrote:

var buf = new Buffer([1,2,3])> buf.toJSON()[ 1, 2, 3 ]

With buffer in the browser I get {type: 'Buffer', data: [...]}. Obviously
you're doing this intentionally, since the code does exactly this. However,
I wonder why you've chosen to do it this way? At the very least,
documenting the difference will save users problems when it works
differently than they expect.

—
Reply to this email directly or view it on GitHub
#34.

Feross | blog http://feross.org/ | webtorrent http://webtorrent.io/ |
studynotes http://www.apstudynotes.org/

[humphd]

Ah, that's really useful, thanks for the info. You should consider calling this out in your README.

[feross]

Added a note to the readme, thanks!