Disallow template literal placeholder syntax in regular strings (no-template-curly-in-string) #594

Closed
feross opened this Issue Aug 19, 2016 · 3 comments

Projects

None yet

2 participants

@feross
Owner
feross commented Aug 19, 2016 edited

ECMAScript 6 allows programmers to create strings containing variable or expressions using template literals, instead of string concatenation, by writing expressions like ${variable} between two backtick quotes (). It can be easy to use the wrong quotes when wanting to use template literals, by writing"${variable}", and end up with the literal value"${variable}"` instead of a string containing the value of the injected expressions.

This rule aims to warn when a regular string contains what looks like a template literal placeholder. It will warn when it finds a string containing the template literal place holder (${something}) that uses either " or ' for the quotes.

http://eslint.org/docs/rules/no-template-curly-in-string

Likely to be uncontroversial and only one test repo fails so I will merge this into standard v8 beta.

@feross feross modified the milestone: v8 Aug 19, 2016
@feross feross added a commit to feross/eslint-config-standard that closed this issue Aug 19, 2016
@feross Disallow template literal placeholder syntax in regular strings (no-t…
…emplate-curly-in-string)

Fixes: feross/standard#594
afc6a0a
@feross feross referenced this issue Aug 19, 2016
Closed

Release proposal: standard v8 #564

16 of 16 tasks complete
@tunnckoCore
tunnckoCore commented Aug 24, 2016 edited

I don't see fit for this restriction. There may not be failing repos, but that's not the case. It's pretty logical to have some template engine working with that to emulate it intentionally.

It's not my case, it's not a problem for me, just wanted to mention it.

edit: This one for example https://github.com/tunnckoCore/es6-template (and it's not the only one, i'm sure) - I don't use it, but it would be a problem for someone.

@feross
Owner
feross commented Aug 25, 2016

@tunnckoCore You can instruct users of polyfills like that one to just add this to the top of their file:

/* eslint-disable no-template-curly-in-string */
@tunnckoCore

Huh, actually, yea. Thanks.

@saadq saadq referenced this issue in nodejs/nodejs.org Aug 25, 2016
Merged

Update dependencies #873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment