Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests fail on macOS Sierra #948

Closed
feross opened this issue Sep 21, 2016 · 1 comment
Closed

Integration tests fail on macOS Sierra #948

feross opened this issue Sep 21, 2016 · 1 comment
Labels
bug

Comments

@feross
Copy link
Member

feross commented Sep 21, 2016 •
edited

So, I updated to macOS Sierra today... Looks like the font rendering changed slightly and the integration tests don't pass for me.

Should we do fuzzy diffing for macOS too? Or can we just update the screenshots for Sierra and not worry about it? In a few months, the majority of our users will be on Sierra, if history is any indication.
@feross feross added the bug label Sep 21, 2016
@feross
Copy link
Member Author

feross commented Oct 5, 2016

Fixed by #1008

@feross feross closed this as completed Oct 5, 2016
@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@feross