New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
desktop: Detect OS architecture for Linux download #100
Conversation
Change the download page to link to the 32-bit Linux download. Use the soon-to-be-published `arch` package (thanks for the npm package name @Raynos!) to detect the OS architecture and conditionally change the link to the 64-bit version. https://github.com/feross/arch
NodeList.prototype.forEach only exists in Chrome and is non-standard. This is super misleading. Fixes it. https://twitter.com/feross/status/776909513697878016
I also went through and made sure all instances of Sheesh. cc @dcposch |
Can I get a review? @dcposch @mathiasvr @Flet @ungoldman @demoneaux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,4 +1,5 @@ | |||
// View-specific code | |||
var pathname = window.location.pathname | |||
if (pathname === '/') require('./views/home')() | |||
if (pathname === '/create') require('./views/create')() | |||
if (/\/create\/?/.test(pathname)) require('./views/create')() | |||
if (/\/desktop\/?/.test(pathname)) require('./views/desktop')() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did this work before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't really. The /create
page was a work-in-progress from the very first version of the site (years ago!). It should probably be removed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like the npm package is published |
You gotta push the button harder |
Change the download page to link to the 32-bit Linux download.
Use the soon-to-be-published
arch
package (thanks for the npm packagename @Raynos!) to detect the OS architecture and conditionally change
the link to the 64-bit version.
https://github.com/feross/arch