Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router embed navigation controller as open #102

Merged
merged 2 commits into from May 14, 2019

Conversation

@ferranabello
Copy link
Owner

commented May 14, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

commented May 14, 2019

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #102   +/-   ##
======================================
  Coverage    98.2%   98.2%           
======================================
  Files           7       7           
  Lines         167     167           
======================================
  Hits          164     164           
  Misses          3       3
Impacted Files Coverage Δ
Viperit/Core/Router.swift 94.44% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d34a9...e19915f. Read the comment docs.

@ferranabello ferranabello merged commit b54c781 into master May 14, 2019

4 checks passed

codebeat no reportable quality changes
Details
codecov/patch 100% of diff hit (target 98.2%)
Details
codecov/project 98.2% (+0%) compared to d6d34a9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ferranabello ferranabello deleted the feature/router-embled-navigation-open branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.