Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getNavigationController function public #103

Merged
merged 1 commit into from May 17, 2019

Conversation

@ferranabello
Copy link
Owner

commented May 17, 2019

  • Make getNavigationController function public
  • Use router's viewController accessor instead of force casting
  • Extend RouterProtocol instead of Router class if it makes sense
  • Bump version number to 1.3.2
- Make getNavigationController function public
- Use router's viewController accessor instead of force casting
- Extend RouterProtocol instead of Router class if it makes sense
- Bump version number to 1.3.2
@codecov

This comment has been minimized.

Copy link

commented May 17, 2019

Codecov Report

Merging #103 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage    98.2%   98.19%   -0.02%     
==========================================
  Files           7        7              
  Lines         167      166       -1     
==========================================
- Hits          164      163       -1     
  Misses          3        3
Impacted Files Coverage Δ
Viperit/Core/Router.swift 94.33% <100%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54c781...cca02b1. Read the comment docs.

@ferranabello ferranabello merged commit 961052d into master May 17, 2019

4 checks passed

codebeat no reportable quality changes
Details
codecov/patch 100% of diff hit (target 98.2%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +1.79% compared to b54c781
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ferranabello ferranabello deleted the feature/router branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.