Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router function to present modal views #90

Merged
merged 2 commits into from Dec 11, 2018

Conversation

@ferranabello
Copy link
Owner

commented Dec 10, 2018

func present(from: UIViewController, embedInNavController: Bool, presentationStyle: UIModalPresentationStyle, transitionStyle: UIModalTransitionStyle, setupData: Any?, completion: (() -> Void)?)
@codecov

This comment has been minimized.

Copy link

commented Dec 10, 2018

Codecov Report

Merging #90 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   97.02%   97.22%   +0.19%     
==========================================
  Files           8        8              
  Lines         101      108       +7     
==========================================
+ Hits           98      105       +7     
  Misses          3        3
Impacted Files Coverage Δ
Viperit/Core/Router.swift 91.17% <100%> (+2.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0769a3b...954def8. Read the comment docs.

@ferranabello ferranabello reopened this Dec 10, 2018

@ferranabello ferranabello merged commit ec367c8 into master Dec 11, 2018

3 of 4 checks passed

codebeat 0 issues resolved and 1 introduced
Details
codecov/patch 100% of diff hit (target 97.02%)
Details
codecov/project 97.22% (+0.19%) compared to 0769a3b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ferranabello ferranabello deleted the feature/router-modal branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.