Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language improvement, cleanup and support #455

Open
Albino-Zoe opened this Issue Mar 8, 2017 · 20 comments

Comments

Projects
None yet
4 participants
@Albino-Zoe
Copy link

Albino-Zoe commented Mar 8, 2017

Hello,

it would be possible for you to look at the created table?
Matrix_Werte_CanZE_1_22.xlsx

I have selected from all screens which values ​​are displayed and in which way.
It appears that sometimes a slightly different name may have been chosen for the same value.
This can be confusing.
I think it's good if it's always the same name.
Do you also see it like that?

For example (Refer to the table for details on the screen name):

No.2 Echte Kapazität (SOC) (%) -> Real State of Charge (%)
No.3 Echter Ladestatus % -> Real state of Charge (%)

No.6 Temperatur der Batteriemodule (°C) -> Battery Modules Temperatures (°C)
No.7 Temperaturen -> Battery modules temperatures [°C]

No.12 Mögliche Ladeleistung kW -> Available Charging Power kW
No.13 Ladeleistung kW -> Charger Power (kW)
No.14 Wechselspannung [kW] -> AC power [kW]

No.17 Gleichstromleistung kW -> DC Power kW
No.18 Gleichstromladeleistung (kW) -> DC Charging Power(kW)

No.19 Reichweite (km) -> Range (km)
No.20 Verfügbare Reichweite -> Available range
No.21 Verfügbare Reichweite (km) -> Available distance (km)

No.39 Kapazität (%) -> State of Charge (%)
No.40 Ladezustand [%] -> State of charge [%]

No.48 Max AC Ladestrom Pilot Amp -> Max AC charge pilot Amp
No.49 Pilotsignal (A) -> Pilot amp (A)

Perhaps it is also partially a different value, I'm not sure, I'am a "Newbie".

I would find this table also generally useful, maybe you want to use it for the HP ?
Here is also the option to add, which values ​​are currently displayed in the car.
This creates clarity, which values ​​are only displayed so far in the car and what CanZE additionally displays.

Last but not least the reference to a few small writing errors, etc.

screen Consumption: Power (kw) -> Power (kW)

screen Climate: Kühlungsstatus Tracktionsbatterie -> Kühlungsstatus Traktionsbatterie
screen Climate: Compressor RPM -Translation-> Kompressor UpM
screen Climate: Kühlungmodus der Traktionsbatterie -> Kühlungsmodus der Traktionsbatterie

screen Charging: Energy consumed kWh -Translation-> ??? (bisheriger Akkuverbrauch)

screen Charging Prediction: AC power [kW] -Translation-> Wechselspannung [kW] ???

KW is the unit of measure for power,
but the German word "Wechselspannung" describes only the abbreviation AC.
"AC Leistung [kW]" should be the correct translation.

I am looking forward to feedback.


Zoe Intens R240 (25.08.2016) 25.000km/Jahr CanZE (Android) (V1.22) mit KW902 ELM327 (27.01.2017)

@fesch

This comment has been minimized.

Copy link
Owner

fesch commented Mar 8, 2017

You should try to use Git, clone the repo, make all corrections and then make a merge-request. :-)

German translations have been merged from 3 sources, so I did not pay attention on this while merging. But you are right, different names for the same things should be avoided.

@Albino-Zoe

This comment has been minimized.

Copy link
Author

Albino-Zoe commented Mar 8, 2017

Hi,
I know ... open source ;-)

but also the English names are sometimes different :-(

If I knew so well in Canze know that I can say what each value means, then I could also say to 100%, if it are the same values ​​... but in the moment I can not do that ;-)

I am sure there are enough experts who can correct this very quickly or make comments :-)

@Albino-Zoe

This comment has been minimized.

Copy link
Author

Albino-Zoe commented Mar 11, 2017

Hello,

Please do not use the file "Matrix_Werte_CanZE_1_22.xlsx", there are some faults.
I have solved my questions based on V1.24 myself :-)
The following values ​​have different names and should be unified because they represent the same value in other screens.

Remark: [xx] The measuring unit is behind the value and not in the name

English:


Screen: BATTERY
Value: Real State of Charge (%)

Screen: CHARGING (Main)
Value: Real state of charge (%)

Screen: CHARGING (Technical)
Value: Real state of charge (%)

suggestion: Real state of charge (%)


Screen: BATTERY
Value: Battery Modules Temperatures (°C)

Screen: CHARGING (Technical)
Value: Battery modules temperatures [°C]

Screen: TEMPERATURE HEATMAP
Value: Battery modules temperatures

suggestion: Battery modules temperatures (°C)


Screen: CHARGING (Main)
Value: Available Charging Power kW

Screen: CHARGING GRAPHS
Value: Charger power (kW)

Screen: CHARGING PREDICTION
Value: AC power [kW]

suggestion: Available charging power (kW)


Screen: CHARGING (Main)
Value: DC Power kW

Screen: CHARGING (Technical)
Value: DC Power kW

Screen: CLIMATE
Value: DC Power kW

Screen: CHARGING GRAPHS
Value: DC Charging power (kW)

suggestion: DC charging power (kW)


Screen: CONSUMPTION
Value: Range (km)

Screen: CHARGING (Main)
Value: Available range

Screen: CHARGING (Technical)
Value: Available range

Screen: RANGE
Value: Available distance (km)

suggestion: Available distance (km)


Screen: CONSUMPTION
Value: State of Charge (%)

Screen: CHARGING PREDICTION
Value: State of charge [%]

suggestion: State of charge (%)


Screen: CHARGING (Technical)
Value: Max AC charge pilot Amp

Screen: CHARGING GRAPH
Value: Pilot amp (A)

suggestion:
Pilot amp (A)


This pleases me if you have the same opinion.
Then the correction should begin.
The adjustment in German is quite easy to do then.

I' d like to support you.

@Albino-Zoe

This comment has been minimized.

Copy link
Author

Albino-Zoe commented Mar 15, 2017

@yoh-there

This comment has been minimized.

Copy link
Collaborator

yoh-there commented Mar 17, 2017

I have tried to group the xml entries on a per screen basis but the language editor, which is a great help, will not maintain that, and string resources are simply appended at the end. Maybe we should let go of that plan.

@Albino-Zoe

This comment has been minimized.

Copy link
Author

Albino-Zoe commented Feb 7, 2019

Do you want to finish the topic completely or only the planned procedure?
I know, here https://www.goingelectric.de/forum/viewtopic.php?f=57&t=22468&p=934006#p934006 also missing a final answer :-(

I'm not a programmer / developer :-(
I also have not understood yet, where are these information to be found in the appropriate language? In source code somewhere or per language in an extra file?

@yoh-there

This comment has been minimized.

Copy link
Collaborator

yoh-there commented Feb 9, 2019

Thanks for the link. I am not the only developer but let me be completely frank on this one. Accept my apologies if I seems to sound rudely Dutch ;-)

  • The issue of the wording is absolutely valid, but also has a low priority. It doesn't hamper functionality at all and the people actually working on it tend to put there focus there. This is why I kept the issue open. I think we agree that this is a different issue than just unequal wording for the same field.

  • the comments in that thread rub me the wrong way. If somebody thinks things need to be done, well, the always hated open source argument: step in and so something. And if those somebodies don't like me or Bob executing their holy wishes, well, too bad. We see a lot of nonsensical or out of scope or not very interesting requests/demands. This is not directed at you, you put in detailed comments, thank you.

  • Most people willing to step in for translation do only one shot translations but the then files are orphaned. For me personally, I will maintain the English and the Dutch version and that's it.

  • The language file for German is here: https://github.com/fesch/CanZE/blob/master/app/src/main/res/values-de/strings.xml . The English one, which is leading, is here https://github.com/fesch/CanZE/blob/master/app/src/main/res/values/strings.xml . Best thing is to make a clone and put in merge requests, but I really understand using git can feel intimidating and therefor I am happy to accept a bare XML file and simply replace that in the source, no problem, and always appreciated.

@yoh-there

This comment has been minimized.

Copy link
Collaborator

yoh-there commented Feb 10, 2019

Most of the comments done in English and Dutch, some of the German already in commit #2deb082. I propose to close this issue. It is a continuous process and I think it is wise to have permanent language owners with an established update process and ditch languages for which there is no owner. Calling @fesch for extra opinion.

I am happy to adopt English and Dutch, but I would prefer somebody else. Never good to assess your own meat.

@fesch

This comment has been minimized.

Copy link
Owner

fesch commented Feb 10, 2019

Everyone may have his opinion: Mine is, that such apps should be always in English, so please forgive me if I'm out of all this.

I support multi-lang support for those of you willing to provide translations, but I will neither do some, nor use some ...

@yoh-there

This comment has been minimized.

Copy link
Collaborator

yoh-there commented Feb 10, 2019

I tend to agree and it's in line with above suggestion to either have a owner, or ditch altogether. Let's wait a few days because of the latest release, then put a request-for-owners up the blog and ditch the languages that are not taken up in say two weeks.

We could put out an extra item on goingelectric.de and forumpro.fr. For the Dutch I will ask in the local forum. I would not be surprised if nearly nobody used it, in which case I will most certainly ditch that one.

We could then focus more on consistent language / capitals / etc use, which I do believe is a valid point.

Leaving this open then until we decide

@yoh-there

This comment has been minimized.

Copy link
Collaborator

yoh-there commented Feb 12, 2019

Quick poll in the Dutch forum showed no more than lukewarm interest in the ongoing translation. The few answers I got were along the lines of "EN or DE is fine. NL is kinda cute, but not if it eats into development stuff". The numbers might not be very representative and the Dutch, given the language is tiny, are in general OK with English in apps and stuff.

@cedricberger

This comment has been minimized.

Copy link
Contributor

cedricberger commented Feb 18, 2019

Hi,
I just brought up the question in the french forum (http://renault-zoe.forumpro.fr/t13655-traduction-francaise-de-canze)
Since some see value in having french translations, and are motivated to help,
we will try to organize ourselves to maintain the french translations.

I will have a closer look to see how much work it is.
Hopefully I should be able to submit pull requests for modifications in the french translations file...

@yoh-there

This comment has been minimized.

Copy link
Collaborator

yoh-there commented Feb 18, 2019

Hi Cedric, that is appreciated. The French file is locate here for peeks

https://github.com/fesch/CanZE/blob/master/app/src/main/res/values-fr/strings.xml

@yoh-there

This comment has been minimized.

Copy link
Collaborator

yoh-there commented Feb 18, 2019

Cedric, I saw your last post in the french forum. I have no problem sending out a warning if a release is imminent, and Android Studio (or almost any decent git client) has very good diff features.

@yoh-there

This comment has been minimized.

Copy link
Collaborator

yoh-there commented Feb 21, 2019

Dear @cedricberger @Albino-Zoe I noticed that the threads on your local forums went quiet. Being the impatient guy I can be I was wondering if you think you or one of your forum members could be the committed maintainer for French and German (by far the biggest user group) respectively. It is not hard to do, but to make it work it would need:

  • a commitment to keep maintaining the language or find another maintainer when you can't anymore;
  • use git for version control. I would strongly advice to also use Android Studio, but I realize that is a massive software system with a learning curve. The upside though is you can actually see the end result on different device sizes. Or try out for yourself what is in the development pipeline ;-)

From my end (and I think @fesch would agree), I am willing to give notice a few days before a release, and help out getting into the flow of a pull- change - commit - push - merge request.

@yoh-there yoh-there changed the title Screen matrix (Android) -> Same values with different names? Language improvement, cleanup and support Feb 21, 2019

@cedricberger

This comment has been minimized.

Copy link
Contributor

cedricberger commented Feb 21, 2019

Ok, I am willing to be the commiter for the french translations.

For now what I am trying to figure out, is how I could do to easily collaborate with others (from the french forum), to be able to review translations together.
But this is not a showstopper anyway.

@yoh-there

This comment has been minimized.

Copy link
Collaborator

yoh-there commented Feb 21, 2019

That is great, thank you!

Best way to process is to make a fork from the project, switch to the development branch, always pull the latest commits in from the main project (I promise from now on I won't touch the .fr XML file so you should have no merge conflicts), make changes, push hem to your fork and then request a merge. It sounds complicated but it's really easy once you get the hang of it.

As for collaboration: the ideal model in my opinion would be for them to do exactly the same with you fork, but that is probably massive overkill ;-)

@cedricberger

This comment has been minimized.

Copy link
Contributor

cedricberger commented Mar 4, 2019

I submitted a pull request for the french translations!
Let me know if it is OK...
If possible, keep the 2 commits (not squashed), since one only refactors the declarations (removed comments, same order as English file), the other makes the actual modifications.

@yoh-there

This comment has been minimized.

Copy link
Collaborator

yoh-there commented Mar 4, 2019

@cedricberger Nice, thank you!

@Albino-Zoe any progress re. the German contributors?

I think we need announce ditching Slovenian. There are less than 30 users if I didn't misinterpret the play store console.

@yoh-there

This comment has been minimized.

Copy link
Collaborator

yoh-there commented Mar 17, 2019

Placeholder for changes impacting language files in the next release. I'll edit this while working on changes.

Many unused resources are removed
New activity All Data
BCB activity removed and functionality moved to Chargingtech and header_ChargerKeyParameters changed to header_GridParameters
Query DTCs shortened for 3 column layout
Elm Dump removed
LeafSpy refactored to Dash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.