AEA-1610 fix: add check consistency of package versions (#2459) #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcofavorito
requested review from
DavidMinarsch and
solarw
and removed request for
DavidMinarsch
marcofavorito
commented
Jun 7, 2021
| @@ -202,6 +202,9 @@ def __str__(self) -> str: | |||
| return str(self.value) | |||
|
|
|||
|
|
|||
| PackageIdPrefix = Tuple[ComponentType, str, str] | |||
There was a problem hiding this comment.
helper type, more readable, and does not affect much code (it replaces Tuple[ComponentType, str, str])
There was a problem hiding this comment.
Yeah is backward compatible too I guess.
marcofavorito
commented
Jun 7, 2021
| self.conflicting_packages = conflicting_packages | ||
| super().__init__(self._build_error_message()) | ||
|
|
||
| def _build_error_message(self) -> str: |
There was a problem hiding this comment.
for an example of the generated message, see below:
https://github.com/fetchai/agents-aea/pull/2550/files#diff-5a86c9151c53eb9b7fde346e231dc88a7b18f51ff369081b9116ef1c02423bddR604
marcofavorito
commented
Jun 7, 2021
Comment on lines
+639
to
+647
| self.manager.start_manager() | ||
| weather_station_id = PublicId.from_str("fetchai/weather_station:0.27.0") | ||
| self.manager.add_project(weather_station_id) | ||
| weather_client_id = PublicId.from_str("fetchai/weather_client:0.27.0") | ||
| with pytest.raises( | ||
| ProjectPackageConsistencyCheckError, | ||
| match=re.escape(self.EXPECTED_ERROR_MESSAGE), | ||
| ): | ||
| self.manager.add_project(weather_client_id) |
There was a problem hiding this comment.
this is the code to reproduce issue #2459
DavidMinarsch
approved these changes
Jun 8, 2021
| self._prefix_to_components = ( | ||
| {} | ||
| ) # type: Dict[Tuple[ComponentType, str, str], Set[ComponentId]] | ||
| self._prefix_to_components = {} # type: Dict[PackageIdPrefix, Set[ComponentId]] |
There was a problem hiding this comment.
I assume this is just refactoring of typing, i.e. no material change?
| @@ -202,6 +202,9 @@ def __str__(self) -> str: | |||
| return str(self.value) | |||
|
|
|||
|
|
|||
| PackageIdPrefix = Tuple[ComponentType, str, str] | |||
There was a problem hiding this comment.
Yeah is backward compatible too I guess.
marcofavorito
added a commit
that referenced
this pull request
Jun 8, 2021
10 tasks
DavidMinarsch
added a commit
that referenced
this pull request
Jun 8, 2021
Fill coverage gap in manager.py (due to #2550)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add consistency of package versions in MAM.
MAM should track all versions of packages and raise an exception when incompatible versions of any packages are added. Otherwise, this can lead to problems at runtime (with whatever version being loaded last being in memory).
This PR addresses the above issue.
Fixes
Fix #2459
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.Further comments
n/a