Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add robot specific information on rosparam #22

Merged
merged 1 commit into from Dec 28, 2018

Conversation

Projects
None yet
3 participants
@k-okada
Copy link
Contributor

commented May 10, 2018

please see ros-infrastructure/rep#104 for the background,
since we have several robots and would like to have common interface for getting robot type/names

@moriarty
Copy link
Member

left a comment

LGTM. @cjds should this be tested?

Also, it should go into indigo-devel, and melodic-devel.
ATM: Melodic devel hasn't diverged from indigo-devel but it will with #24 so we should merge this before really branching off melodic-devel

@moriarty

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

I just noticed the ros-infrastructure/rep#104 is still an open PR, but it seems reasonable, I think we could merge this without that becoming an official standard, but then I guess it only needs to go into the melodic-devel branch.

@cjds

cjds approved these changes Dec 28, 2018

Copy link
Contributor

left a comment

@moriarty tested already and LGTM

@moriarty moriarty merged commit 15ea7bd into fetchrobotics:indigo-devel Dec 28, 2018

@moriarty

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

@k-okada Thanks for the PR!

@cjds I squash & merged to indigo-devel, because that’s where the original PR was opened for, and we still need to release the rest of the melodic stuff.

We can just move melodic-devel branch ahead to include this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.