Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPEN-8 Add autodocking to default robot launch #28

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@erelson
Copy link
Contributor

commented Feb 12, 2019

Pending testing...

Suddenly not sure if it makes sense to bump the version in package.xml, also...

@erelson erelson requested a review from moriarty Feb 12, 2019

@moriarty

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

I was planning on doing a bump of all versions before we bloom, not just a patch bump.

@moriarty
Copy link
Member

left a comment

LGTM.

We should collect all of our versions and maybe do a 0.x+1.0 version bump once we've done a test on melodic and before we bloom.

@erelson

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

Tested and this portion works fine (in indigo). Merging, as any issue is probably going to be in the fetch_open_auto_dock repo instead.

@erelson erelson force-pushed the erelson:auto_dock_default_on branch from 4ece987 to 3ff14b7 Feb 13, 2019

@erelson erelson force-pushed the erelson:auto_dock_default_on branch from 3ff14b7 to 1ba566c Feb 13, 2019

@erelson erelson merged commit 6e08176 into fetchrobotics:melodic-devel Feb 13, 2019

@erelson erelson deleted the erelson:auto_dock_default_on branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.