Build on GHC 7.0.x #15

Closed
mightybyte opened this Issue Mar 7, 2013 · 3 comments

Projects

None yet

2 participants

@mightybyte

Any chance we can get this package to build on GHC 7.0.x? The Snap Framework commits to supporting the past few major Haskell Platform releases and for now that includes GHC 7.0. Right now our buildbot is getting a build failure from smallcheck.

Test/SmallCheck/Series.hs:29:14:
    Unsupported extension: DefaultSignatures
@feuerbach
Owner

Right now our buildbot is getting a build failure from smallcheck.

Perhaps you need to specify an upper version bound? SmallCheck 1.0 is a major release and contains many API-breaking changes (see this post for details). So even if this issue is resolved, you'd still need to upgrade your code. There's nothing wrong with the old version, and you can continue using it if it does the job.

That said, yes, I think it's possible to fix. In the middle of developing 1.0 I used DefaultSignatures in an essential way and so had given up on old GHCs. But I've just realised that since then I've rewritten those parts without DefaultSignatures, and right now they are only used for generic Serial instances.

So it should be enough put back the CPP macro guards (like the ones that were present in the earlier versions). If you have time to do that, test with GHC 7.0.x and send a pull request, I'd be happy to apply it.

@mightybyte

Perhaps you need to specify an upper version bound? SmallCheck 1.0 is a major release and contains many API-breaking changes (see this post for details). So even if this issue is resolved, you'd still need to upgrade your code.

I wasn't using smallcheck before 1.0, so it's not about the upgrade. Specifying an upper bound did temporarily solve my problem though.

I pushed a fix that adds back the ifdefs to my fork at https://github.com/mightybyte/smallcheck/, but I haven't yet had a chance to test it on GHC 7.0. It builds on 7.6 though.

@feuerbach
Owner

Closing this for now. If desirable, please re-open with a pull request.

@feuerbach feuerbach closed this Jun 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment