Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use shell command as editor #210

Merged
merged 1 commit into from Nov 9, 2019
Merged

Add ability to use shell command as editor #210

merged 1 commit into from Nov 9, 2019

Conversation

@cblp
Copy link
Member

cblp commented Nov 6, 2019

This change is Reviewable

@cblp cblp requested a review from willbasky Nov 6, 2019
@willbasky

This comment has been minimized.

Copy link
Contributor

willbasky commented Nov 6, 2019


ff-core/lib/FF.hs, line 612 at r1 (raw file):
VISUAL это переменная для редакторов текстовых?

Copy link
Contributor

willbasky left a comment

Reviewed 3 of 5 files at r1.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @willbasky)

Copy link
Member Author

cblp left a comment

Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @willbasky)


ff-core/lib/FF.hs, line 612 at r1 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

VISUAL это переменная для редакторов текстовых?

да, https://unix.stackexchange.com/questions/4859/visual-vs-editor-what-s-the-difference

@willbasky

This comment has been minimized.

Copy link
Contributor

willbasky commented Nov 6, 2019


ff-core/lib/FF/Options.hs, line 391 at r1 (raw file):
Это для футера?

Copy link
Contributor

willbasky left a comment

Reviewed 1 of 5 files at r1.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @cblp and @willbasky)

Copy link
Member Author

cblp left a comment

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @willbasky)


ff-core/lib/FF/Options.hs, line 391 at r1 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

Это для футера?

да, может, ещё для чего-нибудь

Copy link
Contributor

willbasky left a comment

Reviewed 1 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@cblp cblp force-pushed the editor-command branch from 66982f3 to e12f2a9 Nov 7, 2019
Copy link
Contributor

willbasky left a comment

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@willbasky willbasky merged commit 24b903d into master Nov 9, 2019
2 checks passed
2 checks passed
code-review/reviewable 6 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@willbasky willbasky deleted the editor-command branch Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.