New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Faker::Unit for faking Units including metric system and english system #92

Merged
merged 1 commit into from Nov 16, 2013

Conversation

Projects
None yet
3 participants
@lurraca
Contributor

lurraca commented Nov 15, 2013

Additional units and metric systems could be added.

Added Faker::Unit for faking Units including metric system and englis…
…h system

Additional units and metric system could be added.
@lurraca

This comment has been minimized.

Show comment
Hide comment
@lurraca

lurraca Nov 15, 2013

Contributor

I see that the test for 1.8.7 is failing in Travis CI, does that look like an issue on my part?

Contributor

lurraca commented Nov 15, 2013

I see that the test for 1.8.7 is failing in Travis CI, does that look like an issue on my part?

@gotjosh

This comment has been minimized.

Show comment
Hide comment
@gotjosh

gotjosh commented Nov 15, 2013

+1 👍

@EmmanuelOga

This comment has been minimized.

Show comment
Hide comment
@EmmanuelOga

EmmanuelOga Nov 16, 2013

Contributor

txs!

Contributor

EmmanuelOga commented Nov 16, 2013

txs!

EmmanuelOga added a commit that referenced this pull request Nov 16, 2013

Merge pull request #92 from lurraca/master
Added Faker::Unit for faking Units including metric system and english system

@EmmanuelOga EmmanuelOga merged commit 6097a0a into ffaker:master Nov 16, 2013

1 check failed

default The Travis CI build failed
Details
@EmmanuelOga

This comment has been minimized.

Show comment
Hide comment
@EmmanuelOga

EmmanuelOga Nov 16, 2013

Contributor

Not sure why this project ALWAYS fails in travis. I've been running each realease on my machine with 1.8.7, 1.9.3 and 2.0 w/o errors.

Contributor

EmmanuelOga commented Nov 16, 2013

Not sure why this project ALWAYS fails in travis. I've been running each realease on my machine with 1.8.7, 1.9.3 and 2.0 w/o errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment