Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opening bracket as requirement for function matching #23

Merged
merged 1 commit into from
Oct 6, 2019

Conversation

JunShern
Copy link
Contributor

@JunShern JunShern commented Oct 5, 2019

When looking for instances of our function, add the requirement that the function name needs to be followed with a '(' character.

Otherwise for example if we have two functions, myFunc and myFunc1 and we are looking for myFunc, then the second function will be mistakenly matched. By including the '(', we will search for myFunc( and thus myFunc1 will not be matched.

@JunShern JunShern changed the title Add opening brace as requirement for function matching Add opening bracket as requirement for function matching Oct 5, 2019
@ffd8 ffd8 merged commit d8ad484 into ffd8:develop Oct 6, 2019
@ffd8
Copy link
Owner

ffd8 commented Oct 6, 2019

Another good catch – I mis-read what you were checking here.. good idea to check for the ( when comparing where the function is called to avoid similar named ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants