Remove old code for 'blocking: true' on Ruby before 2.0 #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All supported ruby versions have rb_thread_call_without_gvl() and rb_thread_call_without_gvl(), so that we can finally get rid of the old code. This improves readability of Function.c a lot.
benoittgt
added a commit
to rspec/rspec-support
that referenced
this pull request
May 18, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
benoittgt
added a commit
to rspec/rspec-expectations
that referenced
this pull request
May 18, 2019
benoittgt
added a commit
to rspec/rspec-collection_matchers
that referenced
this pull request
May 18, 2019
benoittgt
added a commit
to rspec/rspec-collection_matchers
that referenced
this pull request
May 18, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
benoittgt
added a commit
to rspec/rspec-collection_matchers
that referenced
this pull request
May 18, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
benoittgt
added a commit
to rspec/rspec-support
that referenced
this pull request
May 18, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
benoittgt
added a commit
to rspec/rspec-expectations
that referenced
this pull request
May 18, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
benoittgt
added a commit
to benoittgt/rspec-mocks
that referenced
this pull request
May 18, 2019
benoittgt
added a commit
to rspec/rspec-mocks
that referenced
this pull request
May 18, 2019
JonRowe
pushed a commit
to rspec/rspec-mocks
that referenced
this pull request
May 19, 2019
benoittgt
added a commit
to rspec/rspec-collection_matchers
that referenced
this pull request
May 19, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
benoittgt
added a commit
to rspec/rspec-expectations
that referenced
this pull request
May 19, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
benoittgt
added a commit
to rspec/rspec-support
that referenced
this pull request
May 19, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
benoittgt
added a commit
to rspec/rspec-collection_matchers
that referenced
this pull request
May 19, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
benoittgt
added a commit
to rspec/rspec-expectations
that referenced
this pull request
May 19, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
JonRowe
pushed a commit
to rspec/rspec-expectations
that referenced
this pull request
May 20, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
JonRowe
pushed a commit
to rspec/rspec-mocks
that referenced
this pull request
Jun 13, 2019
JonRowe
pushed a commit
to rspec/rspec-mocks
that referenced
this pull request
Jun 13, 2019
JonRowe
pushed a commit
to rspec/rspec-expectations
that referenced
this pull request
Oct 7, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…#1276) ffi/ffi#683 Related: - ffi/ffi#699 --- This commit was imported from rspec/rspec-mocks@2182ced.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…c-expectations#1115) CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699 --- This commit was imported from rspec/rspec-expectations@dbf72e5.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…#1276) ffi/ffi#683 Related: - ffi/ffi#699 --- This commit was imported from rspec/rspec-mocks@5f3f68f.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…c-expectations#1115) CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699 --- This commit was imported from rspec/rspec-expectations@1044d4e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All supported ruby versions have
rb_thread_call_without_gvl()andrb_thread_call_without_gvl(), so that we can finally get rid of the old code.This improves readability of
Function.ca lot.