Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to msvcrt.dll as LIBC on MINGW #790

Merged
merged 3 commits into from Jun 9, 2020
Merged

Conversation

@larskanis
Copy link
Member

larskanis commented Jun 5, 2020

ffi-1.13.0 switched FFI::Library::LIBC from msvcrt.dll to ucrtbase.dll as part of #779 in commit c674683 .

As described in #788 ucrtbase.dll has behavioural changes which shouldn't be released as part of a minor version change of ffi. While the change makes sense for mswin, we revert it for mingw.

Fixes #788

larskanis added 3 commits Jun 5, 2020
ffi-1.13.0 switched FFI::Library::LIBC from msvcrt.dll to ucrtbase.dll
as part of #779 in commit c674683 .

As described in #788 ucrtbase.dll has behavioural changes which
shouldn't be released as part of a minor version change of ffi.
While the change makes sense for mswin, we revert it for mingw.

Fixes #788
Since libc is reverted to msvcrt.dll, we can use classic time() function again.
@larskanis larskanis merged commit 18370af into ffi:master Jun 9, 2020
24 of 27 checks passed
24 of 27 checks passed
system-libffi (ubuntu, --disable-system-libffi)
Details
system-libffi (ubuntu, --enable-system-libffi)
Details
system-libffi (macos, --disable-system-libffi)
Details
system-libffi (macos, --enable-system-libffi)
Details
system-libffi (windows, --disable-system-libffi)
Details
system-libffi (windows, --enable-system-libffi)
Details
specs (ubuntu, 2.3)
Details
specs (ubuntu, 2.4)
Details
specs (ubuntu, 2.5)
Details
specs (ubuntu, 2.6)
Details
specs (ubuntu, 2.7)
Details
specs (ubuntu, ruby-head)
Details
specs (ubuntu, truffleruby-head)
Details
specs (macos, 2.3)
Details
specs (macos, 2.4)
Details
specs (macos, 2.5)
Details
specs (macos, 2.6)
Details
specs (macos, 2.7)
Details
specs (macos, ruby-head)
Details
specs (macos, truffleruby-head)
Details
specs (windows, 2.4)
Details
specs (windows, 2.5)
Details
specs (windows, 2.6)
Details
specs (windows, 2.7)
Details
specs (windows, ruby-head) specs (windows, ruby-head)
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.