node infobox coords link os switch #13

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@petabyteboy
Contributor

petabyteboy commented Dec 18, 2015

Link to the "geo:"-URL on Android while linking to flopp.net otherwise

...
finally

@tcatm

This comment has been minimized.

Show comment
Hide comment
@tcatm

tcatm Dec 18, 2015

I don't think this makes much sense. I believe systems other than Android may be able to parse geo-URIs and systems that don't can provide a helpful error message. One can always click on the nodename itself to see it centered on the map.

tcatm commented Dec 18, 2015

I don't think this makes much sense. I believe systems other than Android may be able to parse geo-URIs and systems that don't can provide a helpful error message. One can always click on the nodename itself to see it centered on the map.

@@ -28,10 +28,18 @@ define(["moment", "numeral", "tablesort", "tablesort.numeric"],
var latitude = d.nodeinfo.location.latitude
var longitude = d.nodeinfo.location.longitude
var a = document.createElement("a")
- a.textContent = showLatitude(latitude) + " " +
+ a.innerHTML = showLatitude(latitude) + " " +

This comment has been minimized.

@tcatm

tcatm Dec 18, 2015

Don't ever do this! Instead, createTextNodes and append to the parent.

@tcatm

tcatm Dec 18, 2015

Don't ever do this! Instead, createTextNodes and append to the parent.

@petabyteboy

This comment has been minimized.

Show comment
Hide comment
@petabyteboy

petabyteboy Dec 18, 2015

Contributor

The fact is that iOS doesn't throw a useful error and can't handle geo links, nor does Windows (I haven't tested that myself though). People see the link, click / tap it and just get a useless error "can't open blah blah".

Contributor

petabyteboy commented Dec 18, 2015

The fact is that iOS doesn't throw a useful error and can't handle geo links, nor does Windows (I haven't tested that myself though). People see the link, click / tap it and just get a useless error "can't open blah blah".

@tcatm

This comment has been minimized.

Show comment
Hide comment
@tcatm

tcatm Dec 18, 2015

Well, it doesn't break anything. In the worst case, pressing the back button will bring people back to the meshviewer.

tcatm commented Dec 18, 2015

Well, it doesn't break anything. In the worst case, pressing the back button will bring people back to the meshviewer.

@jplitza

This comment has been minimized.

Show comment
Hide comment
@jplitza

jplitza Dec 18, 2015

Member

Firefox under any OS can be taught how to handle geo:-URIs, so I also use them on my desktop.

Furthermore, why on earth would you link to flopp.net? At first glance, that seems to be some kind of geocaching site, which has absolutely nothing to do with Freifunk. I would understand linking to either OSM or Google, but nothing else.

Member

jplitza commented Dec 18, 2015

Firefox under any OS can be taught how to handle geo:-URIs, so I also use them on my desktop.

Furthermore, why on earth would you link to flopp.net? At first glance, that seems to be some kind of geocaching site, which has absolutely nothing to do with Freifunk. I would understand linking to either OSM or Google, but nothing else.

@petabyteboy

This comment has been minimized.

Show comment
Hide comment
@petabyteboy

petabyteboy Dec 19, 2015

Contributor

Flopp provides OSM and sattelite at the same time

Contributor

petabyteboy commented Dec 19, 2015

Flopp provides OSM and sattelite at the same time

@petabyteboy

This comment has been minimized.

Show comment
Hide comment
@petabyteboy

petabyteboy Dec 19, 2015

Contributor

Maybe @Adorfer can elaborate on this

Contributor

petabyteboy commented Dec 19, 2015

Maybe @Adorfer can elaborate on this

@Adorfer

This comment has been minimized.

Show comment
Hide comment
@Adorfer

Adorfer Dec 19, 2015

@jplitza
Flopp provides besides different OSM styles and DOP the possibity to set markers, to make projections (distance + angle), set areals and creating shortlinks for all of this.
e.G.: http://goo.gl/07jssy

Adorfer commented Dec 19, 2015

@jplitza
Flopp provides besides different OSM styles and DOP the possibity to set markers, to make projections (distance + angle), set areals and creating shortlinks for all of this.
e.G.: http://goo.gl/07jssy

@tcatm

This comment has been minimized.

Show comment
Hide comment
@tcatm

tcatm Dec 19, 2015

We could change the format to something that can be copy-pasted into various forms (e.g. on flopp.net).

tcatm commented Dec 19, 2015

We could change the format to something that can be copy-pasted into various forms (e.g. on flopp.net).

@Adorfer

This comment has been minimized.

Show comment
Hide comment
@Adorfer

Adorfer Dec 19, 2015

I forgot to mention: Additional "bonus" for flopp.net: It's on github!
https://github.com/flopp/FloppsTolleKarte

Adorfer commented Dec 19, 2015

I forgot to mention: Additional "bonus" for flopp.net: It's on github!
https://github.com/flopp/FloppsTolleKarte

@Adorfer Adorfer referenced this pull request in flopp/FloppsMap Dec 19, 2015

Closed

"Freifunk" Popup #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment