New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lavfi/drawutils: improve colorspace support #33
Conversation
|
There is an issue in commit bd1d5b7: |
|
There are issues in commit a16b7a3: |
|
/submit |
|
Error: Ignoring PR with empty title and/or body |
|
/submit |
|
There is an issue in commit bd1d5b7: |
|
There are issues in commit a16b7a3: |
Do you think I should drop this check? But then it would go yellow on Patchwork (like this: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220602055636.3585381-1-wenbin.chen@intel.com/) |
Signed-off-by: rcombs <rcombs@rcombs.me>
|
/submit |
|
There is an issue in commit d80e1b2: |
1 similar comment
|
There is an issue in commit d80e1b2: |
- Introduce ff_draw_init2, which takes explicit colorspace and range args - Use lavu/csp and lavfi/colorspace for conversion, rather than the lavu/colorspace.h macros - Use the passed-in colorspace when performing RGB->YUV conversions The upshot of this is: - Support for YUV spaces other than BT601 - Better rounding for all conversions - Particular rounding improvements in >8-bit formats, which previously used simple left-shifts - Support for limited-range RGB - Support for full-range YUV in non-J pixfmts Due to the rounding improvements, this results in a large number of minor changes to FATE tests. Signed-off-by: rcombs <rcombs@rcombs.me>
|
/submit |
|
Submitted as pull.33.ffstaging.FFmpeg.1654192626.ffmpegagent@gmail.com To fetch this version into To fetch this version to local tag |
|
merged upstream |
This introduces
ff_draw_init2, adding support for colorspaces other than BT601 and explicit full/limited range configuration.