Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lavfi/drawutils: improve colorspace support #33

Closed
wants to merge 2 commits into from

Conversation

rcombs
Copy link

@rcombs rcombs commented Jun 2, 2022

This introduces ff_draw_init2, adding support for colorspaces other than BT601 and explicit full/limited range configuration.

@ffmpeg-codebot
Copy link

ffmpeg-codebot bot commented Jun 2, 2022

There is an issue in commit bd1d5b7:
Commit not signed off

@ffmpeg-codebot
Copy link

ffmpeg-codebot bot commented Jun 2, 2022

There are issues in commit a16b7a3:
Please wrap lines in the body of the commit message between 60 and 72 characters.
Commit not signed off

@rcombs
Copy link
Author

rcombs commented Jun 2, 2022

/submit

@ffmpeg-codebot
Copy link

ffmpeg-codebot bot commented Jun 2, 2022

Error: Ignoring PR with empty title and/or body

@rcombs
Copy link
Author

rcombs commented Jun 2, 2022

/submit

@ffmpeg-codebot
Copy link

ffmpeg-codebot bot commented Jun 2, 2022

There is an issue in commit bd1d5b7:
Commit not signed off

@ffmpeg-codebot
Copy link

ffmpeg-codebot bot commented Jun 2, 2022

There are issues in commit a16b7a3:
Please wrap lines in the body of the commit message between 60 and 72 characters.
Commit not signed off

@softworkz
Copy link
Collaborator

There are issues in commit a16b7a3: Please wrap lines in the body of the commit message between 60 and 72 characters. Commit not signed off

Do you think I should drop this check?

But then it would go yellow on Patchwork (like this: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220602055636.3585381-1-wenbin.chen@intel.com/)

Signed-off-by: rcombs <rcombs@rcombs.me>
@rcombs
Copy link
Author

rcombs commented Jun 2, 2022

/submit

@ffmpeg-codebot
Copy link

ffmpeg-codebot bot commented Jun 2, 2022

There is an issue in commit d80e1b2:
Please wrap lines in the body of the commit message between 60 and 72 characters.

1 similar comment
@ffmpeg-codebot
Copy link

ffmpeg-codebot bot commented Jun 2, 2022

There is an issue in commit d80e1b2:
Please wrap lines in the body of the commit message between 60 and 72 characters.

- Introduce ff_draw_init2, which takes explicit colorspace and range
  args
- Use lavu/csp and lavfi/colorspace for conversion, rather than the
  lavu/colorspace.h macros
- Use the passed-in colorspace when performing RGB->YUV conversions

The upshot of this is:
- Support for YUV spaces other than BT601
- Better rounding for all conversions
- Particular rounding improvements in >8-bit formats, which previously
  used simple left-shifts
- Support for limited-range RGB
- Support for full-range YUV in non-J pixfmts

Due to the rounding improvements, this results in a large number of
minor changes to FATE tests.

Signed-off-by: rcombs <rcombs@rcombs.me>
@rcombs
Copy link
Author

rcombs commented Jun 2, 2022

/submit

@ffmpeg-codebot
Copy link

ffmpeg-codebot bot commented Jun 2, 2022

Submitted as pull.33.ffstaging.FFmpeg.1654192626.ffmpegagent@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-33/rcombs/drawutils-v1

To fetch this version to local tag pr-ffstaging-33/rcombs/drawutils-v1:

git fetch --no-tags https://github.com/ffstaging/FFmpeg tag pr-ffstaging-33/rcombs/drawutils-v1

@softworkz
Copy link
Collaborator

merged upstream

@softworkz softworkz closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants