From 9522ba5fbf028a6b43b80e837ec18a97ff2b7d28 Mon Sep 17 00:00:00 2001 From: Guilherme Guy Date: Thu, 28 Oct 2021 22:34:02 -0300 Subject: [PATCH 1/2] [HOTFIX] fix - Fix validation error on form --- src/questionario/questionario.service.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/questionario/questionario.service.ts b/src/questionario/questionario.service.ts index 21e6ef0..47c78a1 100644 --- a/src/questionario/questionario.service.ts +++ b/src/questionario/questionario.service.ts @@ -27,9 +27,8 @@ export class QuestionService { // verify regex for (const answer of surveyResponse.answers) { - const question = await this.questionModel.findOne({ - id: answer.questionId, - }); + const question = await this.questionModel.findById(answer.questionId); + const regex = new RegExp(question.validationRegex); sentFields.add(question.id); From b8b3d8a98b321f0a1301834c6acd02c60a831928 Mon Sep 17 00:00:00 2001 From: Guilherme Guy Date: Thu, 28 Oct 2021 22:44:35 -0300 Subject: [PATCH 2/2] [HOTFIX] test - Update test to match fix --- test/questionario/questionario.service.spec.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/test/questionario/questionario.service.spec.ts b/test/questionario/questionario.service.spec.ts index 6603810..917f33a 100644 --- a/test/questionario/questionario.service.spec.ts +++ b/test/questionario/questionario.service.spec.ts @@ -81,9 +81,9 @@ describe('QuestionService', () => { sort: () => result, }; }, - findOne: (data) => { + findById: (id) => { return defaultData.filter((element) => { - return element['id'] === data['id']; + return element['id'] === id; })[0]; }, }, @@ -105,10 +105,6 @@ describe('QuestionService', () => { questionId: '1', response: 'Joao', }, - { - questionId: '2', - response: 'Ricardo', - }, ], };